commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [csv] type name consistency
Date Sat, 14 Sep 2013 09:27:45 GMT
On 14 September 2013 09:20, Emmanuel Bourg <ebourg@apache.org> wrote:
> Le 13/09/2013 13:22, Benedikt Ritter a écrit :
>
>> I'll change this if nobody objects.
>
> I'm still not convinced by the renaming of Quote as a matter of
> consistency. Does it mean that any new public class added to the package
> in the future will have to be prefixed by "CSV" as well? That seems a
> bit weird to me. It should be prefixed when it really makes sense.
>
> 'Quote' is short and not likely to conflict with other classes (unlike
> Parser and Format). I would keep it as is.

+1

There is one other inconsistency that might be worth addressing: all
the classes are final apart from CSVFormat.
Should it be final? If not, the reason needs documenting as it is
different from the rest of the code.

> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message