commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: [VOTE] Release Apache Commons Pool 2.0 RC2 as 2.0
Date Fri, 01 Nov 2013 12:53:15 GMT
On 01/11/2013 12:27, Benedikt Ritter wrote:
> Hello Mark,
> 
> again building with:

Thanks again for the testing.

> 
> Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
> 17:22:22+0200)
> Maven home: /Applications/dev/maven/apache-maven-3.1.1
> Java version: 1.7.0_40, vendor: Oracle Corporation
> Java home:
> /Library/Java/JavaVirtualMachines/jdk1.7.0_40.jdk/Contents/Home/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "mac os x", version: "10.9", arch: "x86_64", family: "mac"
> 
> - build works fine
> - compared source archives with tag: content is the same
> - signatures are ok
> - Site looks good, the one FindBugs issue has been resolved but there is a
> new one:
> 
> new org.apache.commons.pool2.proxy.JdkProxySource(ClassLoader, Class[]) may
> expose internal representation by storing an externally mutable object into
> JdkProxySource.interfaces
> 
> Again I cannot say if this a problem, because I'm not involved in the
> development of pool. Maybe others can comment on this?

It is an issue and I have fixed it in trunk. It slipped through as it
only became an issue when I changed the visibility of the class.

There were also some niggles with the site build that were fixed post tag.

> All my points from RC1 have been addressed, thanks for that.

No problem. Thanks for the review. I've further improved the code
coverage of the tests since RC2 as well.

> +1
> 
> Benedikt

I'm tempted to push to release RC2 as the issues are minor. However,
since they have all been fixed in trunk and the release process isn't
anywhere near as painful as I was expecting, I'll probably aim to do a
(hopefully final) RC3 later today.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message