commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [VOTE] Release Apache Commons Pool 2.0 RC2 as 2.0
Date Fri, 01 Nov 2013 14:06:55 GMT
+1

BUT:

- We could use a migration guide, even if it just says "change the package
name from ...pool to ....pool2."

- Not a blocker but should be addressed, from the RAT report:

Unapproved licenses:

  src/site/resources/download_pool.cgi

- Findbugs reports one MALICIOUS_CODE item, which we should either fix by
copying the array or Javadoc such that someone looking the report can click
on the source link and see the code comment.

There is one class with 0% code coverage, not ideal for a new major
release:
https://people.apache.org/~markt/dev/commons-pool-2.0-RC2/cobertura/org.apache.commons.pool2.impl.DefaultPooledObjectInfo.html

I do not understand the "N/A" for some of the other classes in the
Cobertura report.

- The release history report is missing version 1.6 (I'll take the blame on
that one since I cut the 1.6 release).

Tested with:

Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da; 2013-02-19
08:51:28-0500)
Maven home: C:\Java\apache-maven-3.0.5\bin\..
Java version: 1.7.0_45, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.7.0_45\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"

With Maven 3.1.1, it bombs with:

[INFO] Scanning for projects...
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] Building Apache Commons Pool 2.0
[INFO]
------------------------------------------------------------------------
[INFO]
[INFO] --- maven-site-plugin:3.2:site (default-site) @ commons-pool2 ---
[WARNING] Error injecting:
org.apache.maven.reporting.exec.DefaultMavenReportExecutor
java.lang.NoClassDefFoundError: org/sonatype/aether/graph/DependencyFilter
        at java.lang.Class.getDeclaredConstructors0(Native Method)
        at java.lang.Class.privateGetDeclaredConstructors(Class.java:2493)
        at java.lang.Class.getDeclaredConstructors(Class.java:1901)
        at
com.google.inject.spi.InjectionPoint.forConstructorOf(InjectionPoint.java:245)
        at
com.google.inject.internal.ConstructorBindingImpl.create(ConstructorBindingImpl.java:99)
        at
com.google.inject.internal.InjectorImpl.createUninitializedBinding(InjectorImpl.java:653)
        at
com.google.inject.internal.InjectorImpl.createJustInTimeBinding(InjectorImpl.java:863)
        at
com.google.inject.internal.InjectorImpl.createJustInTimeBindingRecursive(InjectorImpl.java:790)
        at
com.google.inject.internal.InjectorImpl.getJustInTimeBinding(InjectorImpl.java:278)
        at
com.google.inject.internal.InjectorImpl.getBindingOrThrow(InjectorImpl.java:210)
        at
com.google.inject.internal.InjectorImpl.getProviderOrThrow(InjectorImpl.java:986)
        at
com.google.inject.internal.InjectorImpl.getProvider(InjectorImpl.java:1019)
        at
com.google.inject.internal.InjectorImpl.getProvider(InjectorImpl.java:982)
        at
com.google.inject.internal.InjectorImpl.getInstance(InjectorImpl.java:1032)
        at
org.eclipse.sisu.space.AbstractDeferredClass.get(AbstractDeferredClass.java:48)
        at
com.google.inject.internal.ProviderInternalFactory.provision(ProviderInternalFactory.java:86)
        at
com.google.inject.internal.InternalFactoryToInitializableAdapter.provision(InternalFactoryToInitializableAdapter.java:55)
        at
com.google.inject.internal.ProviderInternalFactory$1.call(ProviderInternalFactory.java:70)
        at
com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision(ProvisionListenerStackCallback.java:100)
        at
org.eclipse.sisu.plexus.PlexusLifecycleManager.onProvision(PlexusLifecycleManager.java:133)
        at
com.google.inject.internal.ProvisionListenerStackCallback$Provision.provision(ProvisionListenerStackCallback.java:109)
        at
com.google.inject.internal.ProvisionListenerStackCallback.provision(ProvisionListenerStackCallback.java:55)
        at
com.google.inject.internal.ProviderInternalFactory.circularGet(ProviderInternalFactory.java:68)
        at
com.google.inject.internal.InternalFactoryToInitializableAdapter.get(InternalFactoryToInitializableAdapter.java:47)
        at
com.google.inject.internal.ProviderToInternalFactoryAdapter$1.call(ProviderToInternalFactoryAdapter.java:46)
        at
com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1054)
        at
com.google.inject.internal.ProviderToInternalFactoryAdapter.get(ProviderToInternalFactoryAdapter.java:40)
        at com.google.inject.Scopes$1$1.get(Scopes.java:59)
        at
com.google.inject.internal.InternalFactoryToProviderAdapter.get(InternalFactoryToProviderAdapter.java:41)
        at
com.google.inject.internal.InjectorImpl$2$1.call(InjectorImpl.java:997)
        at
com.google.inject.internal.InjectorImpl.callInContext(InjectorImpl.java:1047)
        at
com.google.inject.internal.InjectorImpl$2.get(InjectorImpl.java:993)
        at
org.eclipse.sisu.inject.LazyBeanEntry.getValue(LazyBeanEntry.java:82)
        at
org.eclipse.sisu.plexus.LazyPlexusBean.getValue(LazyPlexusBean.java:51)
        at
org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:260)
        at
org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:240)
        at
org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.java:234)
        at
org.apache.maven.plugins.site.AbstractSiteRenderingMojo.getReports(AbstractSiteRenderingMojo.java:229)
        at org.apache.maven.plugins.site.SiteMojo.execute(SiteMojo.java:121)
        at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:106)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
        at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
        at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
        at
org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
        at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:317)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:152)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:555)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:214)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:158)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: java.lang.ClassNotFoundException:
org.sonatype.aether.graph.DependencyFilter
        at
org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
        at
org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:259)
        at
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:235)
        at
org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:227)
        ... 60 more
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 5.479s
[INFO] Finished at: Fri Nov 01 10:05:36 EDT 2013
[INFO] Final Memory: 14M/152M
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.2:site (default-site) on
project commons-pool2: Execution default-site of goal
org.apache.maven.plugins:maven-site-plugin:3.2:site failed: A required
class was missing while executing org.apach
.maven.plugins:maven-site-plugin:3.2:site:
org/sonatype/aether/graph/DependencyFilter
[ERROR] -----------------------------------------------------
[ERROR] realm =    plugin>org.apache.maven.plugins:maven-site-plugin:3.2
[ERROR] strategy =
org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/plugins/maven-site-plugin/3.2/maven-site-plugin-3.2.jar
[ERROR] urls[1] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/wagon/wagon-ssh/2.3/wagon-ssh-2.3.jar
[ERROR] urls[2] =
file:/C:/Users/ggregory/.m2/repository/com/jcraft/jsch/0.1.44-1/jsch-0.1.44-1.jar
[ERROR] urls[3] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/wagon/wagon-ssh-common/2.3/wagon-ssh-common-2.3.jar
[ERROR] urls[4] =
file:/C:/Users/ggregory/.m2/repository/org/codehaus/plexus/plexus-interactivity-api/1.0-alpha-6/plexus-interactivity-api-1.0-alpha-6.jar
[ERROR] urls[5] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/reporting/maven-reporting-exec/1.0.2/maven-reporting-exec-1.0.2.jar
[ERROR] urls[6] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/reporting/maven-reporting-api/3.0/maven-reporting-api-3.0.jar
[ERROR] urls[7] =
file:/C:/Users/ggregory/.m2/repository/velocity/velocity/1.5/velocity-1.5.jar
[ERROR] urls[8] =
file:/C:/Users/ggregory/.m2/repository/org/sonatype/aether/aether-util/1.7/aether-util-1.7.jar
[ERROR] urls[9] =
file:/C:/Users/ggregory/.m2/repository/org/sonatype/sisu/sisu-inject-bean/1.4.2/sisu-inject-bean-1.4.2.jar
[ERROR] urls[10] =
file:/C:/Users/ggregory/.m2/repository/org/sonatype/sisu/sisu-guice/2.1.7/sisu-guice-2.1.7-noaop.jar
[ERROR] urls[11] =
file:/C:/Users/ggregory/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.14/plexus-interpolation-1.14.jar
[ERROR] urls[12] =
file:/C:/Users/ggregory/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.5.5/plexus-component-annotations-1.5.5.jar
[ERROR] urls[13] =
file:/C:/Users/ggregory/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar
[ERROR] urls[14] =
file:/C:/Users/ggregory/.m2/repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar
[ERROR] urls[15] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/maven-archiver/2.4.2/maven-archiver-2.4.2.jar
[ERROR] urls[16] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/doxia/doxia-sink-api/1.3/doxia-sink-api-1.3.jar
[ERROR] urls[17] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/doxia/doxia-logging-api/1.3/doxia-logging-api-1.3.jar
[ERROR] urls[18] =
file:/C:/Users/ggregory/.m2/repository/junit/junit/3.8.1/junit-3.8.1.jar
[ERROR] urls[19] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/doxia/doxia-core/1.3/doxia-core-1.3.jar
[ERROR] urls[20] =
file:/C:/Users/ggregory/.m2/repository/xerces/xercesImpl/2.9.1/xercesImpl-2.9.1.jar
[ERROR] urls[21] =
file:/C:/Users/ggregory/.m2/repository/xml-apis/xml-apis/1.3.04/xml-apis-1.3.04.jar
[ERROR] urls[22] =
file:/C:/Users/ggregory/.m2/repository/org/apache/httpcomponents/httpclient/4.0.2/httpclient-4.0.2.jar
[ERROR] urls[23] =
file:/C:/Users/ggregory/.m2/repository/commons-logging/commons-logging/1.1.1/commons-logging-1.1.1.jar
[ERROR] urls[24] =
file:/C:/Users/ggregory/.m2/repository/commons-codec/commons-codec/1.3/commons-codec-1.3.jar
[ERROR] urls[25] =
file:/C:/Users/ggregory/.m2/repository/org/apache/httpcomponents/httpcore/4.0.1/httpcore-4.0.1.jar
[ERROR] urls[26] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/doxia/doxia-module-xhtml/1.3/doxia-module-xhtml-1.3.jar
[ERROR] urls[27] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/doxia/doxia-module-apt/1.3/doxia-module-apt-1.3.jar
[ERROR] urls[28] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/doxia/doxia-module-xdoc/1.3/doxia-module-xdoc-1.3.jar
[ERROR] urls[29] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/doxia/doxia-module-fml/1.3/doxia-module-fml-1.3.jar
[ERROR] urls[30] =
file:/C:/Users/ggregory/.m2/repository/javax/servlet/servlet-api/2.5/servlet-api-2.5.jar
[ERROR] urls[31] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/doxia/doxia-decoration-model/1.3/doxia-decoration-model-1.3.jar
[ERROR] urls[32] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/doxia/doxia-site-renderer/1.3/doxia-site-renderer-1.3.jar
[ERROR] urls[33] =
file:/C:/Users/ggregory/.m2/repository/org/apache/velocity/velocity-tools/2.0/velocity-tools-2.0.jar
[ERROR] urls[34] =
file:/C:/Users/ggregory/.m2/repository/commons-beanutils/commons-beanutils/1.7.0/commons-beanutils-1.7.0.jar
[ERROR] urls[35] =
file:/C:/Users/ggregory/.m2/repository/commons-digester/commons-digester/1.8/commons-digester-1.8.jar
[ERROR] urls[36] =
file:/C:/Users/ggregory/.m2/repository/commons-chain/commons-chain/1.1/commons-chain-1.1.jar
[ERROR] urls[37] =
file:/C:/Users/ggregory/.m2/repository/commons-validator/commons-validator/1.3.1/commons-validator-1.3.1.jar
[ERROR] urls[38] =
file:/C:/Users/ggregory/.m2/repository/dom4j/dom4j/1.1/dom4j-1.1.jar
[ERROR] urls[39] =
file:/C:/Users/ggregory/.m2/repository/sslext/sslext/1.2-0/sslext-1.2-0.jar
[ERROR] urls[40] =
file:/C:/Users/ggregory/.m2/repository/org/apache/struts/struts-core/1.3.8/struts-core-1.3.8.jar
[ERROR] urls[41] =
file:/C:/Users/ggregory/.m2/repository/antlr/antlr/2.7.2/antlr-2.7.2.jar
[ERROR] urls[42] =
file:/C:/Users/ggregory/.m2/repository/org/apache/struts/struts-taglib/1.3.8/struts-taglib-1.3.8.jar
[ERROR] urls[43] =
file:/C:/Users/ggregory/.m2/repository/org/apache/struts/struts-tiles/1.3.8/struts-tiles-1.3.8.jar
[ERROR] urls[44] =
file:/C:/Users/ggregory/.m2/repository/commons-collections/commons-collections/3.2.1/commons-collections-3.2.1.jar
[ERROR] urls[45] =
file:/C:/Users/ggregory/.m2/repository/org/apache/maven/doxia/doxia-integration-tools/1.5/doxia-integration-tools-1.5.jar
[ERROR] urls[46] =
file:/C:/Users/ggregory/.m2/repository/org/codehaus/plexus/plexus-archiver/1.0/plexus-archiver-1.0.jar
[ERROR] urls[47] =
file:/C:/Users/ggregory/.m2/repository/org/codehaus/plexus/plexus-io/1.0/plexus-io-1.0.jar
[ERROR] urls[48] =
file:/C:/Users/ggregory/.m2/repository/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar
[ERROR] urls[49] =
file:/C:/Users/ggregory/.m2/repository/org/apache/velocity/velocity/1.5/velocity-1.5.jar
[ERROR] urls[50] =
file:/C:/Users/ggregory/.m2/repository/oro/oro/2.0.8/oro-2.0.8.jar
[ERROR] urls[51] =
file:/C:/Users/ggregory/.m2/repository/org/codehaus/plexus/plexus-velocity/1.1.8/plexus-velocity-1.1.8.jar
[ERROR] urls[52] =
file:/C:/Users/ggregory/.m2/repository/org/codehaus/plexus/plexus-utils/1.5.10/plexus-utils-1.5.10.jar
[ERROR] urls[53] =
file:/C:/Users/ggregory/.m2/repository/org/mortbay/jetty/jetty/6.1.25/jetty-6.1.25.jar
[ERROR] urls[54] =
file:/C:/Users/ggregory/.m2/repository/org/mortbay/jetty/servlet-api/2.5-20081211/servlet-api-2.5-20081211.jar
[ERROR] urls[55] =
file:/C:/Users/ggregory/.m2/repository/org/mortbay/jetty/jetty-util/6.1.25/jetty-util-6.1.25.jar
[ERROR] urls[56] =
file:/C:/Users/ggregory/.m2/repository/commons-lang/commons-lang/2.5/commons-lang-2.5.jar
[ERROR] urls[57] =
file:/C:/Users/ggregory/.m2/repository/commons-io/commons-io/1.4/commons-io-1.4.jar
[ERROR] Number of foreign imports: 1
[ERROR] import: Entry[import  from realm ClassRealm[maven.api, parent:
null]]
[ERROR]
[ERROR] -----------------------------------------------------:
org.sonatype.aether.graph.DependencyFilter
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions,
please read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/AetherClassNotFound

Gary


On Thu, Oct 31, 2013 at 11:02 AM, Mark Thomas <markt@apache.org> wrote:

> Development on Pool 2 is complete and a review of the remaining DBCP
> bugs has not highlighted any that are likely to trigger significant API
> changes in Pool so it is time for a release.
>
>  The Pool 2.0 RC2 is available for review here:
>   https://dist.apache.org/repos/dist/dev/commons/pool/ (r3386)
>
>  Maven artifacts are here:
>   https://repository.apache.org/content/repositories/orgapachecommons-050/
>
>  Details of changes since 1.6 are in the release notes and changelog:
>   https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>
>
> http://people.apache.org/~markt/dev/commons-pool-2.0-RC2/changes-report.html
>
>  The tag is here:
>   http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_0_RC2/
>   (r 1537505)
>
>  Site:
>   http://people.apache.org/~markt/dev/commons-pool-2.0-RC2
>   (Broken links to Javadoc versions expected)
>
>  KEYS:
>   http://www.apache.org/dist/commons/KEYS
>
>   Please review the release candidate and vote.
>   This vote will close no sooner that 72 hours from now
>
>   [ ] +1 Release these artifacts
>   [ ] +0 OK, but...
>   [ ] -0 OK, but really should fix...
>   [ ] -1 I oppose this release because...
>
>
> Cheers,
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message