commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sean Owen <>
Subject Re: [MATH] Interest in large patches for small cleanup / performance changes?
Date Sat, 02 Nov 2013 17:35:17 GMT
On Sat, Nov 2, 2013 at 4:49 PM, Phil Steitz <> wrote:
> If the improvements make a material difference [1], by all means
> open tickets and submit patches.  If they are just cosmetic, my
> personal opinion is this should be done in small commits
> incrementally if at all [2].  It is OK to open master tickets to
> track style / optimization changes and do the work to review and
> commit them incrementally.  The master ticket should be preceded by
> discussion here to make sure we are all in agreement that the
> changes are appropriate.
> You mention quite a few different kinds of thing above.  It is
> probably best to break up into different discussion threads by
> topical area and then open master tickets for the ones we agree to
> fix / standardize.  Regarding the javadoc errors (broken javadoc
> references, missing / incorrect @deprecates), there is no need for
> discussion - just open tickets and we can commit the fixes.

I agree with that. I'm going to file two JIRAs and probably leave it
for now. No point in getting into minutiae.

Let me turn it around: are there general clean-up tasks that people
have wanted to do for a while but not gotten to? Maybe I could take a
request or two and run with them.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message