commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [compress] cutting 1.7?
Date Fri, 20 Dec 2013 17:13:09 GMT
On 2013-12-20, Gary Gregory wrote:

> CPD shows some complex code duplication, is it possible to refactor?

It has been doing so ever since we added CPD reports.  The code is part
of a loop (you'll note the braces are not ballanced, there is one more
closing than opening brace) that contains and mutates lots of local
variables.

The whole bzip packge is a pain on the eye as it has been hand-optimized
for performance - unrolled loops, cached arrays that are reused for
different purposes during different stages of compression to avoid
object creation and more.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message