commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [compress] cutting 1.7?
Date Fri, 20 Dec 2013 17:26:16 GMT
On 20 December 2013 17:07, Stefan Bodewig <bodewig@apache.org> wrote:
> On 2013-12-20, Gary Gregory wrote:
>
>> We get PMD warnings in
>> org.apache.commons.compress.archivers.jar.JarArchiveEntry about methods
>> only calling super.
>
>> Either document that the methods are placeholders for future
>> implementations (TODO) or remove the methods.
>
> Actually it is neither.  If you remove the methods findbugs will
> complain that JarEntry doesn't override equals() - it's a choice between
> Findbugs or PMD being unhappy.

Are you sure?

FIndbugs normally only complains if you only define one of equals and hashCode.
In this case, the class defines both.
I think the methods could be removed.

> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message