commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: svn commit: r1564278 - in /commons/proper/commons-parent/trunk: RELEASE-NOTES.txt pom.xml
Date Wed, 05 Feb 2014 14:18:48 GMT
On Wed, Feb 5, 2014 at 8:50 AM, sebb <sebbaz@gmail.com> wrote:

> On 5 February 2014 13:37, Gary Gregory <garydgregory@gmail.com> wrote:
> > On Wed, Feb 5, 2014 at 7:48 AM, sebb <sebbaz@gmail.com> wrote:
> >
> >> On 4 February 2014 13:01,  <ggregory@apache.org> wrote:
> >> > Author: ggregory
> >> > Date: Tue Feb  4 13:01:31 2014
> >> > New Revision: 1564278
> >> >
> >> > URL: http://svn.apache.org/r1564278
> >> > Log:
> >> > maven-scm-publish-plugin 1.0-beta2 -> 1.0
> >>
> >> -1
> >>
> >> It seems this plugin now requires Maven 3.0
> >> I don't know if this is a bug or is intentional.
> >>
> >
> > documented  = intentional ?
> >
> https://maven.apache.org/plugins/maven-scm-publish-plugin/plugin-info.html
> >
>
> It does seem to be intentional, though they failed to mention the
> updated requirement in the release notes.
>
> >>
> >> It may now be possible to require a minimum of Maven 3.0 for all
> >> Commons components.
> >> M3 was not usable originally due to incompatibilities, mainly with
> >> site generation IIRC.
> >> Perhaps that has now been fixed?
> >>
> >
> > The only problems I've seen is with Maven 3.1.0 is building Log4j2, I
> can't
> > recall what now and I have not checked with 3.1.1 for a while but 311 and
> > log4j2 work fine for simple things like 'mvn test'.
> >
> > My standard command line set up is:
> >
> > Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
> > 11:22:22-0400)
> > Maven home: C:\Java\apache-maven-3.1.1\bin\..
> > Java version: 1.7.0_51, vendor: Oracle Corporation
> > Java home: C:\Program Files\Java\jdk1.7.0_51\jre
> > Default locale: en_US, platform encoding: Cp1252
> > OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> >
> > This is what I've used to RM.
> >
> > I have older JDKs that I use from Eclipse for different projects.
> >
> >
> >>
> >> I'm not saying that we must stay on M2.2.1, but we should not force
> >> the upgrade to M3 unless it is beneficial.
> >> And it should not be forced as a side-effect of a plugin version
> upgrade.
> >>
> >> Also if we do require M3 minimum, this should be added as a
> >> requirement in the pom itself.
> >>
> >
> > Well, that part is easy ;)
> >
> >
> >>
> >> I think we need to investigate why the plugin no longer works on M2
> >> and then decide what to do.
> >>
> >
> > M3 is a prereq as noted in
> >
> https://maven.apache.org/plugins/maven-scm-publish-plugin/plugin-info.html
> >
> > Still -1?
>
> I would be -1 to requiring M3.1.1 if M3.0.5 will do the job.
>

The plugin site takes about requiring 3.0, not 3.1.

I reverted anyway.

Gary


>
> And as I wrote previously, I don't think we should require M3 just
> because scm publish 1.0 now requires it.
> It needs to be a deliberate decision that we wish to abandon support
> for Maven 2.2.1
>
> So at present I am still -1 on the change.
>
> Now it may be possible to use scm 1.0 with M2.2.1.
> I tried moving the scm-publish plugin details into pluginManagement
> and that allows "mvn deploy" to work for commons parent.
> However, I have never used scm publish, and I don't know how to test it
> safely.
>
>
> > Gary
> >
> >
> >> > Modified:
> >> >     commons/proper/commons-parent/trunk/RELEASE-NOTES.txt
> >> >     commons/proper/commons-parent/trunk/pom.xml
> >> >
> >> > Modified: commons/proper/commons-parent/trunk/RELEASE-NOTES.txt
> >> > URL:
> >>
> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/RELEASE-NOTES.txt?rev=1564278&r1=1564277&r2=1564278&view=diff
> >> >
> >>
> ==============================================================================
> >> > --- commons/proper/commons-parent/trunk/RELEASE-NOTES.txt (original)
> >> > +++ commons/proper/commons-parent/trunk/RELEASE-NOTES.txt Tue Feb  4
> >> 13:01:31 2014
> >> > @@ -22,6 +22,7 @@ o                   apache-rat-plugin
> >> >  o                   clirr-maven-plugin                 2.5 -> 2.6.1
> >> >  o                   cobertura-maven-plugin           2.5.2 -> 2.6
> >> >  o                   jacoco-maven-plugin 0.6.3.201306030806 ->
> >> 0.6.4.201312101107
> >> > +o                   maven-scm-publish-plugin     1.0-beta2 -> 1.0
> >> >  o                   Fixed JaCoCo configuration - syntax changed
> >> completely between 0.6.2.x and 0.6.3.x
> >> >  o                   Add commons.compiler.version property so compiler
> >> plugin version can be overridden if necessary
> >> >  o                   Add source archive to Maven artifacts
> >> >
> >> > Modified: commons/proper/commons-parent/trunk/pom.xml
> >> > URL:
> >>
> http://svn.apache.org/viewvc/commons/proper/commons-parent/trunk/pom.xml?rev=1564278&r1=1564277&r2=1564278&view=diff
> >> >
> >>
> ==============================================================================
> >> > --- commons/proper/commons-parent/trunk/pom.xml (original)
> >> > +++ commons/proper/commons-parent/trunk/pom.xml Tue Feb  4 13:01:31
> 2014
> >> > @@ -510,7 +510,7 @@ http://svn.apache.org/repos/asf/commons/
> >> >        <plugin>
> >> >          <groupId>org.apache.maven.plugins</groupId>
> >> >          <artifactId>maven-scm-publish-plugin</artifactId>
> >> > -        <version>1.0-beta-2</version>
> >> > +        <version>1.0</version>
> >> >          <configuration>
> >> >            <content>${project.reporting.outputDirectory}</content>
> >> >            <pubScmUrl>scm:svn:${commons.scmPubUrl}</pubScmUrl>
> >> >
> >> >
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >> For additional commands, e-mail: dev-help@commons.apache.org
> >>
> >>
> >
> >
> > --
> > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > Java Persistence with Hibernate, Second Edition<
> http://www.manning.com/bauer3/>
> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > Spring Batch in Action <http://www.manning.com/templier/>
> > Blog: http://garygregory.wordpress.com
> > Home: http://garygregory.com/
> > Tweet! http://twitter.com/GaryGregory
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message