commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [DBCP] PStmtKey ctors have multiple int paramaters - replace with enums?
Date Wed, 05 Feb 2014 17:31:53 GMT
I like the enum idea.

Are these ints supposed to match up to JDBC constants?

Gary


On Wed, Feb 5, 2014 at 10:55 AM, sebb <sebbaz@gmail.com> wrote:

> The PStmtKey ctors have multiple int parameters:
>
> PStmtKey(String sql, int resultSetType, int resultSetConcurrency)
> PStmtKey(String sql, String catalog, int autoGeneratedKeys) {
> PStmtKey(String sql, String catalog, int resultSetType, int
> resultSetConcurrency)
> public PStmtKey(String sql, String catalog, int resultSetType, int
> resultSetConcurrency, StatementType stmtType)
>
> and
>
> PStmtKey(String sql, String catalog, StatementType stmtType, Integer
> autoGeneratedKeys)
>
> if you count autoboxed code.
>
> These are quite confusing.
> Maybe some or all could be replaced with enums?
>
> resultSetType can only be
>
> ResultSet.TYPE_FORWARD_ONLY, ResultSet.TYPE_SCROLL_INSENSITIVE, or
> ResultSet.TYPE_SCROLL_SENSITIVE
>
> and resultSetConcurrency can only be
>
> ResultSet.CONCUR_READ_ONLY or ResultSet.CONCUR_UPDATABLE
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message