commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Schaible <joerg.schai...@swisspost.com>
Subject Re: svn commit: r1563259 - in /commons/proper/lang/trunk: pom.xml src/changes/changes.xml src/main/java/org/apache/commons/lang3/math/NumberUtils.java src/test/java/org/apache/commons/lang3/math/NumberUtilsTest.java
Date Wed, 05 Feb 2014 07:59:53 GMT
Hi Duncan,

Duncan Jones wrote:

> On 31 January 2014 22:44, Jörg Schaible <joerg.schaible@gmx.de> wrote:
>>
>> -1
>>
>> Please revert, we have that already in
>> org.apache.commons.lang3.Conversion
> 
> Thanks for pointing that out. I've reverted.
> 
> I agree it looks like Conversion might be a better place to put the
> functionality. It seems what I've added is equivalent to (the not yet
> implemented) Conversion.intToByteArrayBe(),
> Conversion.byteArrayBeToInt() and so on. So perhaps to close LANG-341,
> those methods will need to be implemented.

Fine with me.

> 
> Any thoughts on the double/float methods included in LANG-341? I
> wasn't 100% sure of those anyway, but they didn't hurt when being
> added to NumberUtils. Is there a place for those in Conversion?

IMHO, yes. Conversion was all about converting types to bytes and vice 
versa.

- Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message