commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From venkatesha murthy <venkateshamurth...@gmail.com>
Subject Re: [MATH-1120] Needed opinion about support on variations in percentile calculation
Date Thu, 12 Jun 2014 19:50:54 GMT
All comments are incorporated except for type 10 of wkipedia as i couldnt
get a comparing tool to provide.
I have also added min and maxLimits to javadoc.

Please let know.


On Wed, Jun 11, 2014 at 6:27 PM, venkatesha murthy <
venkateshamurthyts@gmail.com> wrote:

>
>
> On Wed, Jun 11, 2014 at 4:10 PM, Gilles <gilles@harfang.homelinux.org>
> wrote:
>
>> On Mon, 9 Jun 2014 20:03:57 +0800 (SGT), venkatesha m wrote:
>>
>>> Hi All,
>>>
>>> I am looking for opinion on the name of the enum for the various
>>> estimation strategies.
>>> This is a public static enum under Percentile and i wish to call it
>>> EstimationTecnique.
>>> Would appreciate if you can provide feedback on the name or the
>>> current proposed name is fine.
>>>
>>> I have the patch attached to MATH-1120
>>> (percentile-wth-estimation-patch) for the reference.
>>>
>>
>> IIUC, in this reference
>>   http://stat.ethz.ch/R-manual/R-devel/library/stats/html/quantile.html
>> what you called "EstimationTechnique" is referred to as "Type".
>>
>> Then the R manual uses a numbering: 1 to 9.
>>
>
> Would it be ok to call it as EstimateType as is mentioned in the
> Wikipedia? (rather than just type since it is about different estimation
> styles/types)? Please let know,
>
>>
>> Was Commons Math's implementation none of those nine types?
>> I wouldn't name the CM's implementation DEFAULT (and the R's manual
>> refers to a paper that recommends "type 8").
>>
>> Commons Math comes very close to R-6 however it is the max and min limits
> as to when x1 and xN needs to be considered that would differ  between CM
> and R6..
>
>
>> If it's OK to keep a tight link to the R's description of the variants,
>> I'd suggest
>>
>> public enum Type {
>>   CM,  // instead of DEFAULT
>>   R_1,
>>   R_2,
>>   R_3,
>>   R_4,
>>   R_5,
>>   R_6,
>>   R_7,
>>   R_8,
>>   R_9,
>>   // TYPE_TEN ?
>> }
>>
>> Agreed taken. Also please let know if R_10 is ok for un-named estimation
> type.(the TYPE_TEN?? that you mention) ?
>
>
>> R_9 is not implemented in the patch. Is it intended?
>> Then on the Wikipedia page there is an unnamed 10th variant, also
>> not implemented.
>>
>> Well yes i didnt go about implementing all of them however initially.
> But; i can add those in the next patch
>
>
>> People knowledgeable in what should be expected from such a
>> functionality are most welcome to provide feedback...
>>
>>
>> Regards,
>> Gilles
>>
>>
>> Thanks so much for the comments.
>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message