commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From CodingFabian <...@git.apache.org>
Subject [GitHub] commons-lang pull request: LANG-877 removes unnecessary string all...
Date Fri, 13 Mar 2015 09:40:06 GMT
GitHub user CodingFabian opened a pull request:

    https://github.com/apache/commons-lang/pull/49

    LANG-877 removes unnecessary string allocation and improves hex writing.

    Removes temporary allocation of char arrays and Strings from unicode escaping.
    This roughly doubles the throughput of the escaping functionality mentioned in
    LANG-877. As a side effect this significantly reduces garbage (for the cases
    where the JVM does not allocate the char arrays / String on stack).
    
    Note that there is a minor duplication / inconsistency which I uncovered.
    CharUtils will use lowercase letters, UnicodeEscaper uppercase.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/CodingFabian/commons-lang LANG-877

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/49.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #49
    
----
commit eaaea2aab23e752841340d44aa41e846dea0a7b9
Author: Fabian Lange <lange.fabian@gmail.com>
Date:   2015-03-13T09:34:26Z

    LANG-877 removes unnecessary string allocation and improves hex writing.
    
    Removes temporary allocation of char arrays and Strings from unicode escaping.
    This roughly doubles the throughput of the escaping functionality mentioned in
    LANG-877. As a side effect this significantly reduces garbage (for the cases
    where the JVM does not allocate the char arrays / String on stack).
    
    Note that there is a minor duplication / inconsistency which I uncovered.
    CharUtils will use lowercase letters, UnicodeEscaper uppercase.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message