commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hendrik Dev <hendrikde...@gmail.com>
Subject Re: [LANG] Add ThreadUtils
Date Sun, 03 May 2015 22:28:41 GMT
Hi Benedikt,

i have opened a new pull request
https://github.com/apache/commons-lang/pull/78 which is based against
the master branch, contains only a single commit and fixes the issues
you named.
Hope thats ok ...

Thanks
Hendrik

On Sun, Apr 26, 2015 at 11:40 AM, Benedikt Ritter <britter@apache.org> wrote:
> Hello Hendrik,
>
> 2015-04-22 21:14 GMT+02:00 Hendrik Dev <hendrikdev22@gmail.com>:
>
>> based on what i understand from this discussion i did some changes,
>> pls see
>> https://github.com/salyh/commons-lang/commit/12edd41ec7563368b03fa540af5c9a127bbfd89d
>> for the diff and
>>
>> https://github.com/salyh/commons-lang/blob/12edd41ec7563368b03fa540af5c9a127bbfd89d/src/main/java/org/apache/commons/lang3/ThreadUtils.java
>> for the class in its current version.
>>
>
> I think we're almost there. Two minor nits remain:
> - what's the difference between "finding" and "selecting"? I think we
> should name all methods findXXX
> - AlwayTruePredicate can be private
>
> I think if we have that we can apply the patch. Since you're an ASF
> committer, you can add it to our svn repository yourself, if you like [1].
>
> Best regards,
> Benedikt
>
> [1] http://markmail.org/message/ylmw7qzx23br4ver
>
>
>>
>> Thanks
>> Hendrik
>>
>> On Wed, Apr 15, 2015 at 2:48 AM, Peter Ansell <ansell.peter@gmail.com>
>> wrote:
>> > On 13 April 2015 at 19:21, Benedikt Ritter <britter@apache.org> wrote:
>> >> 2015-04-13 2:27 GMT+02:00 Matt Benson <gudnabrsam@gmail.com>:
>> >>
>> >>> +1 to what Peter said: it's a functional interface so it is
>> >>> lambda-compatible anyway.
>> >>>
>> >>
>> >> Well, yes it would be a functional interface, but it would lack all the
>> >> default methods defined in java.util.function.Predicate if we don't
>> extend
>> >> it later.
>> >
>> > Agreed, I was trying to get that point across with my last comment:
>> >
>> >>> > > public interface ThreadPredicate extends
>> >>> > java.util.function.Predicate<Thread>
>> >>> >
>> >>> > This change is useful once JDK-8 is the baseline, as it would only
>> add
>> >>> > features (all of the default methods) from Predicate, not remove
any
>> >>> > features or backwards compatibility.
>> >
>> > Cheers,
>> >
>> > Peter
>> >
>> > ---------------------------------------------------------------------
>> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> > For additional commands, e-mail: dev-help@commons.apache.org
>> >
>>
>>
>>
>> --
>> Hendrik Saly (salyh, hendrikdev22)
>> @hendrikdev22
>> PGP: 0x22D7F6EC
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter



-- 
Hendrik Saly (salyh, hendrikdev22)
@hendrikdev22
PGP: 0x22D7F6EC

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message