commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: svn commit: r1680133 - in /commons/proper/pool/trunk: pom.xml src/changes/changes.xml
Date Tue, 19 May 2015 11:19:37 GMT
That is a subtle distinction that is irrelevant IMO. We note certain kind of changes or we
do not, we have to pick the audience, users or developers or both. Provenance is not a qualifying
factor for this decision IMO. Since jar hell can still be an issue for some projects, it might
serve some users to know the dependency tree has changed.
Gary 

-------- Original message --------
From: Benedikt Ritter <britter@apache.org> 
Date: 05/18/2015  23:21  (GMT-08:00) 
To: Commons Developers List <dev@commons.apache.org> 
Subject: Re: svn commit: r1680133 - in /commons/proper/pool/trunk: pom.xml src/changes/changes.xml


I do add this kind of changes to changes.xml if it they have been
contributed. In this case I think attribution of the contributor is more
important. What do you think about that?

Benedikt

2015-05-19 7:56 GMT+02:00 Gary Gregory <garydgregory@gmail.com>:

> Done.
>
> Thank you for keeping a keen eye on commits! :-)
>
> Gary
>
> On Mon, May 18, 2015 at 8:09 PM, Phil Steitz <phil.steitz@gmail.com>
> wrote:
>
> > Not a big deal.  I would just delete the changes entries and that only
> > because the release notes are generated from them.
> >
> > Phil
> >
> >
> >
> > > On May 18, 2015, at 7:38 PM, Gary Gregory <garydgregory@gmail.com>
> > wrote:
> > >
> > > Should I undo the changes.xml and delete the JIRA or just not do it in
> > the
> > > future?
> > >
> > > Gary
> > >
> > >> On Mon, May 18, 2015 at 5:51 PM, sebb <sebbaz@gmail.com> wrote:
> > >>
> > >>> On 19 May 2015 at 00:45, Phil Steitz <phil.steitz@gmail.com>
wrote:
> > >>>> On 5/18/15 4:40 PM, ggregory@apache.org wrote:
> > >>>> Author: ggregory
> > >>>> Date: Mon May 18 23:40:21 2015
> > >>>> New Revision: 1680133
> > >>>>
> > >>>> URL: http://svn.apache.org/r1680133
> > >>>> Log:
> > >>>> [POOL-295] Update tests from JUnit 4.11 to 4.12.
> > >>>>
> > >>>> Modified:
> > >>>>    commons/proper/pool/trunk/pom.xml
> > >>>>    commons/proper/pool/trunk/src/changes/changes.xml
> > >>>>
> > >>>> Modified: commons/proper/pool/trunk/pom.xml
> > >>>> URL:
> > >>
> >
> http://svn.apache.org/viewvc/commons/proper/pool/trunk/pom.xml?rev=1680133&r1=1680132&r2=1680133&view=diff
> > >>
> >
> ==============================================================================
> > >>>> --- commons/proper/pool/trunk/pom.xml (original)
> > >>>> +++ commons/proper/pool/trunk/pom.xml Mon May 18 23:40:21 2015
> > >>>> @@ -117,7 +117,7 @@
> > >>>>     <dependency>
> > >>>>       <groupId>junit</groupId>
> > >>>>       <artifactId>junit</artifactId>
> > >>>> -      <version>4.11</version>
> > >>>> +      <version>4.12</version>
> > >>>>       <scope>test</scope>
> > >>>>     </dependency>
> > >>>>     <dependency>
> > >>>>
> > >>>> Modified: commons/proper/pool/trunk/src/changes/changes.xml
> > >>>> URL:
> > >>
> >
> http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/changes/changes.xml?rev=1680133&r1=1680132&r2=1680133&view=diff
> > >>
> >
> ==============================================================================
> > >>>> --- commons/proper/pool/trunk/src/changes/changes.xml (original)
> > >>>> +++ commons/proper/pool/trunk/src/changes/changes.xml Mon May 18
> > >> 23:40:21 2015
> > >>>> @@ -70,6 +70,9 @@ The <action> type attribute can be add,u
> > >>>>     <action dev="psteitz" type="add" issue="POOL-286">
> > >>>>       Added preparePool method to GenericObjectPool.
> > >>>>     </action>
> > >>>> +    <action dev="ggregory" type="update" issue="POOL-295">
> > >>>> +      Update tests from JUnit 4.11 to 4.12.
> > >>>> +    </action>
> > >>>
> > >>> I don't think we need this kind of change documented in the release
> > >>> notes.
> > >>
> > >> Agreed. Nor is a JIRA really necessary.
> > >>
> > >>> Phil
> > >>>>   </release>
> > >>>>   <release version="2.3" date="2014-12-30" description=
> > >>>> "This is a maintenance release that includes bug fixes and minor
> > >> enhancements.">
> > >>>
> > >>>
> > >>> ---------------------------------------------------------------------
> > >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > >>> For additional commands, e-mail: dev-help@commons.apache.org
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > >> For additional commands, e-mail: dev-help@commons.apache.org
> > >
> > >
> > > --
> > > E-Mail: garydgregory@gmail.com | ggregory@apache.org
> > > Java Persistence with Hibernate, Second Edition
> > > <http://www.manning.com/bauer3/>
> > > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> > > Spring Batch in Action <http://www.manning.com/templier/>
> > > Blog: http://garygregory.wordpress.com
> > > Home: http://garygregory.com/
> > > Tweet! http://twitter.com/GaryGregory
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message