commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1695556 - in /commons/proper/bcel/trunk/src: changes/ main/java/org/apache/commons/bcel6/ main/java/org/apache/commons/bcel6/classfile/ main/java/org/apache/commons/bcel6/util/ main/java/org/apache/commons/bcel6/verifier/statics/ main/java...
Date Thu, 13 Aug 2015 09:16:38 GMT
On 12 August 2015 at 19:20, Dave Brosius <dbrosius@apache.org> wrote:
> The Constants class is used by 3rdparty clients to access fields. I suppose
> this change is ok, given that they need to recompile anyway, but just
> mentioning it.

OK, thanks.

It's quite easy now that there are static imports.

Just replace

implements Constants

 with

"import static ...Constants.*';"

I did not do this for the BCEL code as it pollutes the namespace the
same way as using the interface.

> ---
> <br type="_moz" />
>
> On 2015-08-12 11:29, sebb@apache.org wrote:
>>
>> Author: sebb
>> Date: Wed Aug 12 15:29:23 2015
>> New Revision: 1695556
>>
>> URL: http://svn.apache.org/r1695556
>> Log:
>> BCEL-239 Interfaces should not be used to define constants
>>
>> Modified:
>>     commons/proper/bcel/trunk/src/changes/changes.xml
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message