commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stian Soiland-Reyes <st...@apache.org>
Subject Re: [VOTE] Apache Commons VFS 2.1 rc1
Date Wed, 04 May 2016 12:28:54 GMT
+1 (non-binding)

+1 signatures
+1 hashes
+1 LICENSE, NOTICE
0 README.md says <version>2.0</version>
0 Extra README.txt (confusing)
+1 RELEASE-NOTES.txt
+1 mvn apache-rat:check
+1 maven repository signatures/hashes
+1 maven repository *distribution* matches dist/
0 mvn clean install OK (but 1 test fails on tmpfs)
+1 target/*jar matches binaries
+1 source matches svn tag (minus sandbox/ :-) )
+1 Dependency licenses OK
-1 Unclassified use of encryption libraries Bouncy Castle/Apache
Mina/SSHD/Hadoop/jsch/Jetty (plus some AES128 in DefaultCryptor) - but
Commons VFS is not classified on
http://www.apache.org/licenses/exports/

I won't take a stand on the US Export classification requirement as
https://issues.apache.org/jira/browse/LEGAL-250 has not been resolved
yet.


I get this test error (because my /tmp is mounted with noexec):

Tests run: 90, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 4.259
sec <<< FAILURE! - in
org.apache.commons.vfs2.provider.local.test.LocalProviderTestCase
testExecutable(org.apache.commons.vfs2.test.PermissionsTests)  Time
elapsed: 0.011 sec  <<< FAILURE!
java.lang.AssertionError
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at org.junit.Assert.assertTrue(Assert.java:52)
    at org.apache.commons.vfs2.test.PermissionsTests.testExecutable(PermissionsTests.java:70)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.apache.commons.vfs2.test.AbstractProviderTestCase.runTest(AbstractProviderTestCase.java:218)
    at junit.framework.TestCase.runBare(TestCase.java:141)
    at junit.framework.TestResult$1.protect(TestResult.java:122)
    at junit.framework.TestResult.runProtected(TestResult.java:142)
    at junit.framework.TestResult.run(TestResult.java:125)
    at junit.framework.TestCase.run(TestCase.java:129)
    at junit.framework.TestSuite.runTest(TestSuite.java:252)
    at junit.framework.TestSuite.run(TestSuite.java:247)
    at junit.extensions.TestDecorator.basicRun(TestDecorator.java:23)
    at org.apache.commons.vfs2.test.AbstractTestSuite$1.protect(AbstractTestSuite.java:149)
    at junit.framework.TestResult.runProtected(TestResult.java:142)
    at org.apache.commons.vfs2.test.AbstractTestSuite.run(AbstractTestSuite.java:154)

Building from /var/tmp worked.

I won't fail because of this - I'm probably special still using tmpfs
:)   (And adding conditional testing would mean using the same APIs or
requivalent Java 7 NIO files APIs to see if executable bit is
supported).


Checked with:

stain@biggie:/tmp/vfs/source/commons-vfs-2.1$ mvn -v
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T16:41:47+00:00)
Maven home: /home/stain/software/maven
Java version: 1.8.0_72-internal, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_GB, platform encoding: UTF-8
OS name: "linux", version: "3.16.0-67-generic", arch: "amd64", family: "unix"

On 4 May 2016 at 04:43, Josh Elser <elserj@apache.org> wrote:
> All,
>
> Please consider the following for Apache Commons VFS2 version 2.1 (rc1).
>
> Maven repository:
> https://repository.apache.org/content/repositories/orgapachecommons-1163
> Artifacts: https://dist.apache.org/repos/dist/dev/commons/vfs/ r13511
>
> MD5  commons-vfs-distribution-2.1-bin.tar.gz
> 1192914d1ba6f8ca3a2a688feeff602c
> SHA1 commons-vfs-distribution-2.1-bin.tar.gz
> 285097f1db6cbc9d76ae5bb3adf66a315344a864
> MD5  commons-vfs-distribution-2.1-src.tar.gz
> 0646187562302a7dcfbddb93204fc9eb
> SHA1 commons-vfs-distribution-2.1-src.tar.gz
> 24bab87fd4049b9389acd1b6e272f405630aeb25
> MD5  commons-vfs-distribution-2.1-bin.zip 3785874aa0cda64d68acbb8fb7db8bea
> SHA1 commons-vfs-distribution-2.1-bin.zip
> 942a23fb202b89b1a8432beeb0a66469959e661d
> MD5  commons-vfs-distribution-2.1-src.zip c8ef43d308bed1b3ffcb363c15285176
> SHA1 commons-vfs-distribution-2.1-src.zip
> 1ddf0d218f659766f136894eab0beca504ab9f8c
>
> Signed with 4677D66C from
> https://dist.apache.org/repos/dist/release/commons/KEYS
>
> SVN tag is available at
> https://svn.apache.org/repos/asf/commons/proper/vfs/tags/commons-vfs-project-2.1-RC1/
> r1742212
>
> Staged Maven website:
> http://home.apache.org/~elserj/commons/commons-vfs-2.1/
>
> All reports are available in the provided staged Maven site (see "Project
> Reports" at the root-level as well as under each sub-module). JIRA-generated
> release notes are available in the dist.a.o "Artifacts" repository. Unit
> tests pass and the RC was built util JDK6.
>
> (For Sebb) A direct Clirr link
> http://home.apache.org/~elserj/commons/commons-vfs-2.1/commons-vfs2/clirr-report.html
>
> Changes since rc0:
>
> * Improved release notes and website for compatibility
> * Fixes to pom.xml for building website
>
> This vote will be open for 72-hours, 2016/05/06 0400 UTC.
>
>   [ ] +1 Release these artifacts as version 2.1
>   [ ] 0  OK, but...
>   [ ] -1 I oppose these artifacts as version 2.1 because..
>
> - Josh
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>



-- 
Stian Soiland-Reyes
Apache Taverna (incubating), Apache Commons RDF (incubating)
http://orcid.org/0000-0001-9842-9718

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message