commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Release Commons Text 1.0-beta-1 based on RC4
Date Tue, 07 Feb 2017 11:23:46 GMT
Sorry for coming late to the party.
I've only just noticed two issues with the code:

TEXT-63 - protected mutable fields
TEXT-40 - escape HTML characters only once

Fixing these will break API compatibility.

However, this is beta code and has its own sub-package (neat idea BTW).
So if it's considered OK to break the API for the next release, then
these can be fixed later.

The Announce message should make this clear, as should the website

On 6 February 2017 at 21:52, Rob Tompkins <chtompki@gmail.com> wrote:
>
>
>> On Feb 6, 2017, at 12:43 PM, Romain Manni-Bucau <rmannibucau@gmail.com> wrote:
>>
>> Hi Bruno,
>>
>> can you try export LC_ALL=en_US.UTF-8 ?
>>
>
> I suppose I wait on this for now. I'm curious to see how it shakes out with the LC_ALL
export.
>
> Ray -- as soon as I finish up the release, I would be happy to have another set of hands
with the checkstyle issues and anything else.
>
> Cheers,
> -Rob
>
>> Think some tests can desire to force the locale maybe (have the same having
>> a french locale by default)
>>
>>
>> Romain Manni-Bucau
>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>> <https://blog-rmannibucau.rhcloud.com> | Old Blog
>> <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau>
|
>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
>> <https://javaeefactory-rmannibucau.rhcloud.com>
>>
>> 2017-02-06 18:35 GMT+01:00 Bruno P. Kinoshita <
>> brunodepaulak@yahoo.com.br.invalid>:
>>
>>> Hi Rob,
>>>
>>> Thanks for preparing this beta release! And also thanks for the great work
>>> on [text]!
>>>
>>>
>>> I agree with other votes on the Checkstyle issues as non blockers. And I
>>> can help writing/reviewing the user guide.
>>>
>>> However, I have the following tests failing:
>>>
>>> /* --- snip -- */
>>>
>>> Results :
>>>
>>> Failed tests:
>>> ExtendedMessageFormatTest.testBuiltInChoiceFormat:211->
>>> checkBuiltInFormat:336->checkBuiltInFormat:347->checkBuiltInFormat:376
>>> format Pattern=[1234.5: {0,choice,1#One|2#Two|3#Many {0,number}}],
>>> locale=[null] expected:<1234.5: Many 1[.234,]5> but was:<1234.5: Many
>>> 1[,234.]5>
>>> ExtendedMessageFormatTest.testBuiltInDateTimeFormat:230-
>>>> checkBuiltInFormat:336->checkBuiltInFormat:347->checkBuiltInFormat:376
>>> format Pattern=[1: {0,date,short}], locale=[null] expected:<1: [23/01]/07>
>>> but was:<1: [1/23]/07>
>>> ExtendedMessageFormatTest.testBuiltInNumberFormat:277->
>>> checkBuiltInFormat:336->checkBuiltInFormat:347->checkBuiltInFormat:376
>>> format Pattern=[1: {0,number}], locale=[null] expected:<1: 6[.543,]21>
but
>>> was:<1: 6[,543.]21>
>>> ExtendedMessageFormatTest.testExtendedAndBuiltInFormats:141 null
>>> expected:<Name: JOHN DOE DOB: [23/01/07 Salary: R$ 12.345,]67> but
>>> was:<Name: JOHN DOE DOB: [1/23/07 Salary: $12,345.]67>
>>> ExtendedMessageFormatTest.testOverriddenBuiltinFormat:
>>> 253->checkBuiltInFormat:347->checkBuiltInFormat:376 format Pattern=[1:
>>> {0,date}], locale=[null] expected:<1: [23/01/]2007> but was:<1: [Jan
23,
>>> ]2007>
>>>
>>> Tests run: 476, Failures: 5, Errors: 0, Skipped: 0
>>>
>>> [INFO] ------------------------------------------------------------
>>> ------------
>>> [INFO] BUILD FAILURE
>>> [INFO] ------------------------------------------------------------
>>> ------------
>>> [INFO] Total time: 11.385 s
>>> [INFO] Finished at: 2017-02-06T14:07:52-02:00
>>> [INFO] Final Memory: 30M/328M
>>> [INFO] ------------------------------------------------------------
>>> ------------
>>> /* --- snip -- */
>>>
>>> Here's my env:
>>>
>>> Apache Maven 3.3.9
>>> Maven home: /usr/share/maven
>>> Java version: 1.8.0_111, vendor: Oracle Corporation
>>> Java home: /usr/lib/jvm/java-8-oracle/jre
>>> Default locale: en_US, platform encoding: UTF-8
>>> OS name: "linux", version: "4.4.0-59-generic", arch: "amd64", family:
>>> "unix"
>>>
>>>
>>> Even though the JVM locale seems to be set to en_US, I'm in Brazil right
>>> now with the time in Ubuntu set to local time, as well as the locale (or so
>>> I think). Here's my output of running the `locale` command.
>>>
>>> /* --- snip --- */
>>> $ locale
>>> LANG=en_US.UTF-8
>>> LANGUAGE=en_US
>>> LC_CTYPE=pt_BR.UTF-8
>>> LC_NUMERIC=pt_BR.UTF-8
>>> LC_TIME=pt_BR.UTF-8
>>> LC_COLLATE="en_US.UTF-8"
>>> LC_MONETARY=pt_BR.UTF-8
>>> LC_MESSAGES="en_US.UTF-8"
>>> LC_PAPER=pt_BR.UTF-8
>>> LC_NAME=pt_BR.UTF-8
>>> LC_ADDRESS=pt_BR.UTF-8
>>> LC_TELEPHONE=pt_BR.UTF-8
>>> LC_MEASUREMENT=pt_BR.UTF-8
>>> LC_IDENTIFICATION=pt_BR.UTF-8
>>> LC_ALL=
>>> /* --- snip --- */
>>>
>>> I guess these failing tests would be a blocker issue for this beta
>>> release? I can help making these tests locale-agnostics when I'm back home
>>> (in 72 hours or so?). But my guess is that one would have to specify the
>>> locale on those tests to be US only...
>>>
>>>
>>> Hope that helps, cheers
>>>
>>> Bruno
>>>
>>>
>>>
>>>
>>> ----- Original Message -----
>>> From: Rob Tompkins <chtompki@gmail.com>
>>> To: Commons Developers List <dev@commons.apache.org>
>>> Sent: Monday, 30 January 2017 12:14 PM
>>> Subject: [VOTE] Release Commons Text 1.0-beta-1 based on RC4
>>>
>>> Hello all,
>>>
>>> This is a [VOTE] for releasing Apache Commons Text 1.0-beta-1 (from RC4).
>>>
>>> Tag name:
>>>   commons-text-1.0-beta-1-RC4 (signature can be checked from git using
>>> 'git tag -v')
>>>
>>> Tag URL:
>>>  https://git-wip-us.apache.org/repos/asf?p=commons-text.git;a=commit;h=
>>> 65e4314fbd6c3a8f5c248d07a4ccffc1f0ea8bb9
>>>
>>> Commit ID the tag points at:
>>>   65e4314fbd6c3a8f5c248d07a4ccffc1f0ea8bb9
>>>
>>> Site:
>>>  http://home.apache.org/~chtompki/commons-text-1.0-beta-1-RC4
>>>
>>> Distribution files (committed at revision 18041):
>>>  https://dist.apache.org/repos/dist/dev/commons/text/
>>>
>>> Distribution files hashes (SHA1):
>>>   commons-text-1.0-beta-1-bin.tar.gz
>>>   (SHA: dcedb6acc9e8dee75ef9ebefc3a03d20df1d84af)
>>>   commons-text-1.0-beta-1-bin.zip
>>>   (SHA1: b1fa8083bfdcec354a97c23468aa63082990febe)
>>>   commons-text-1.0-beta-1-src.tar.gz
>>>   (SHA1: 06e7bee6a1a710fb2a68472bbbd3209bdc66802c)
>>>   commons-text-1.0-beta-1-src.zip
>>>   (SHA1: 62f405f55689526ca87fd228ed4ae4a4cf4ad107)
>>>
>>> These are the Maven artifacts and their hashes:
>>>   commons-text-1.0-beta-1-javadoc.jar
>>>   (SHA1: 771928f5f5439dbf75d857b4a8da83646ba854e8)
>>>   commons-text-1.0-beta-1-sources.jar
>>>   (SHA1: 104e0d8fe8791d7e6f0653fee406150e6f80ee0e)
>>>   commons-text-1.0-beta-1-test-sources.jar
>>>   (SHA1: 0e0b2ea171d8f82c4775b0e472c41b316052de8f)
>>>   commons-text-1.0-beta-1-tests.jar
>>>   (SHA1: 664d9d71be733cc8240a4164e6a3971fc9e95578)
>>>   commons-text-1.0-beta-1.jar
>>>   (SHA1: 6ef0390cf936f21e07ed47f34ba7eab0d918606b)
>>>   commons-text-1.0-beta-1.pom
>>>   (SHA1: 7b65ac70d36c5acf3bcad87ed2df9e7eba111726)
>>>
>>> KEYS file to check signatures:
>>>  http://www.apache.org/dist/commons/KEYS
>>>
>>> Maven artifacts:
>>>  https://repository.apache.org/content/repositories/orgapachecommons-1234
>>>
>>> Please select one of the following options[1]:
>>>  [ ] +1 Release it.
>>>  [ ] +0 Go ahead; I don't care.
>>>  [ ] -0 There are a few minor glitches: ...
>>>  [ ] -1 No, do not release it because ...
>>>
>>> This vote will be open at least 72 hours, i.e. until
>>> 2017-02-02T15:00:00Z
>>> (this is UTC time).
>>> --------
>>>
>>> Cheers,
>>> -Rob
>>>
>>> [1] http://apache.org/foundation/voting.html
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>
>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message