commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <brit...@apache.org>
Subject Re: [lang] new concurrency annotations
Date Tue, 18 Apr 2017 06:55:18 GMT
Hi,

> Am 18.04.2017 um 08:36 schrieb Gary Gregory <garydgregory@gmail.com>:
> 
> Hi All:
> 
> We have two styles for the new concurrency annotations in master:
> 
> (1) JCIP
> (2) Apache HttpComponents Core
> 
> I would like to delete (1) in favor of (2). I started this discussion
> inappropriately on a VOTE thread, sorry for the redo.

Yes, this makes sense in the light of the reason you gave on the other thread.

> 
> Then we can proceed with another release candidate.
> 
> Also at issue is where the new annotations belong
> 
> (1) org.apache.commons.lang3.concurrent.annotation (current)
> (2) org.apache.commons.lang3.annotation (my preferred location)

What about (3) org.apache.commons.lang3.concurrent ?

I don’t think it’s good style to package things by their technical nature. Why do annotations
deserve their own package? Why don’t we have o.a.c.l.enum/abstractclass/expection then?
From my PoV its easier to understand if things are packaged by their domain. For this reason
I’d argue @Contract belongs to o.a.c.l.concurrent (without sub package)

Benedikt

> 
> Thoughts?
> 
> Gary
> 
> -- 
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <https://www.amazon.com/gp/product/1617290459/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1617290459&linkCode=as2&tag=garygregory-20&linkId=cadb800f39946ec62ea2b1af9fe6a2b8>
> 
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1617290459>
> JUnit in Action, Second Edition
> <https://www.amazon.com/gp/product/1935182021/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182021&linkCode=as2&tag=garygregory-20&linkId=31ecd1f6b6d1eaf8886ac902a24de418%22>
> 
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182021>
> Spring Batch in Action
> <https://www.amazon.com/gp/product/1935182951/ref=as_li_tl?ie=UTF8&camp=1789&creative=9325&creativeASIN=1935182951&linkCode=%7B%7BlinkCode%7D%7D&tag=garygregory-20&linkId=%7B%7Blink_id%7D%7D%22%3ESpring+Batch+in+Action>
> <http:////ir-na.amazon-adsystem.com/e/ir?t=garygregory-20&l=am2&o=1&a=1935182951>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message