commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdillon <...@git.apache.org>
Subject [GitHub] commons-cli pull request #11: Adjust access-modifier of checkRequiredOptions...
Date Fri, 05 May 2017 23:57:59 GMT
GitHub user jdillon opened a pull request:

    https://github.com/apache/commons-cli/pull/11

    Adjust access-modifier of checkRequiredOptions() to protected

    ... for parity with GnuParser, PosixParser and Parser impls to allow sub-class a bit more
control.
    
    I have a use-case in gshell cli2 which needs to defer the required-options check, which
is doable with GnuParser and PosixParser, but the new DefaultParser doesn't allow this due
to a private access-modifier on checkRequiredOptions().

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jdillon/commons-cli defaultparser-checkrequiredptions-protected

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-cli/pull/11.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #11
    
----
commit 9accb4e89fd4621da6de6681438d6518ef6cb6ab
Author: Jason Dillon <jason@planet57.com>
Date:   2017-05-05T23:53:58Z

    Adjust access-modifier of checkRequiredOptions() to protected for parity with GnuParser
and PosixParser impls to allow sub-class a bit more control

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message