commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chtompki <...@git.apache.org>
Subject [GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Date Fri, 09 Jun 2017 16:02:19 GMT
Github user chtompki commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/45#discussion_r121162518
  
    --- Diff: .travis.yml ---
    @@ -21,8 +21,15 @@ jdk:
       - oraclejdk7
       - oraclejdk8
     
    +services:
    +  - docker
    +
    +before_install:
    +  - docker pull ibmcom/ibmjava:8-sdk
    --- End diff --
    
    I would prefer to use `library/ibmjava:8-jsk` because it's marked on dockerhub as "official"
whereas `ibmcom` is just public. It's a bit curious though. It seems that they both point
to the same place (repository) one points to "master" and one points to a githash.
    
    `ibmcom/ibmjava:8-sdk` - https://github.com/ibmruntimes/ci.docker/blob/master/ibmjava/8/sdk/x86_64/ubuntu/Dockerfile
    
    `library/ibmjava:8-sdk` - https://github.com/ibmruntimes/ci.docker/blob/a9a184211f9feef1f2bdd0330ff8ae95e6c015cf/ibmjava/8/sdk/x86_64/ubuntu/Dockerfile


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message