commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ameyjadiye <...@git.apache.org>
Subject [GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Date Fri, 09 Jun 2017 17:49:06 GMT
Github user ameyjadiye commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/45#discussion_r121184938
  
    --- Diff: .travis.yml ---
    @@ -21,8 +21,15 @@ jdk:
       - oraclejdk7
       - oraclejdk8
     
    +services:
    +  - docker
    +
    +before_install:
    +  - docker pull ibmcom/ibmjava:8-sdk
    --- End diff --
    
    Hi @chtompki , I just [compared](https://www.diffchecker.com/y4s7vOx6) them and found
both Dockerfile belongs to same repository, I took the one from master. Official belongs to
some past commit. I prefer to go with official ``` library/ibmjava:8-sdk ``` though. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message