commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ameyjadiye <...@git.apache.org>
Subject [GitHub] commons-text pull request #45: Added IBM Jdk8 build support to travis-ci con...
Date Fri, 09 Jun 2017 18:06:37 GMT
Github user ameyjadiye commented on a diff in the pull request:

    https://github.com/apache/commons-text/pull/45#discussion_r121188654
  
    --- Diff: .travis.yml ---
    @@ -21,8 +21,15 @@ jdk:
       - oraclejdk7
       - oraclejdk8
     
    +services:
    +  - docker
    +
    +before_install:
    +  - docker pull ibmcom/ibmjava:8-sdk
    +
     script:
       - mvn test apache-rat:check clirr:check checkstyle:check findbugs:check javadoc:javadoc
    +  - docker run -v `pwd`:/work ibmcom/ibmjava:8-sdk /bin/bash -c "apt-get update &&
cd work && apt-get install -y maven && mvn"
    --- End diff --
    
    Hi @britter @garydgregory @chtompki 
    
    Flashed a though, can we use our own image for this ? we can build it from ```library/ibmjava:8-sdk```.
Rather doing ```apt-get update``` and  ```apt-get install -y maven``` again and again on fly
we can just build our own with below Dockerfile  on [Dockerhub](https://hub.docker.com), I
also found we have [apache account](https://hub.docker.com/u/apache/) so it will be easy to
publish it there. same can be reused by some other project in apache. _(that's why commons
is made for anyway :blush: )_
    
    ```
    from library/ibmjava:8-sdk
    
    RUN apt-get update 
    RUN apt-get install -y maven  
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message