commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chtompki <...@git.apache.org>
Subject [GitHub] commons-text issue #45: Added IBM Jdk8 build support to travis-ci configurat...
Date Thu, 15 Jun 2017 13:10:42 GMT
Github user chtompki commented on the issue:

    https://github.com/apache/commons-text/pull/45
  
    I believe the reason that we're getting a "success" to be the fact that the `docker` command
exits with a 0. So might we want to do a `{docker run -v `pwd`:/work library/ibmjava:8-sdk
/bin/bash -c "apt-get update && cd work && apt-get install -y maven &&
mvn} || exit 1` in the docker command.
    
    Further, I've been thinking about this more:
    
    1. I submitted some changes to the official maven docker image (which I think we should
be using). 2. Would we want to have two builds here, one that builds in a bunch of containers,
and a second (presumably running on the target usage jdk) that does the coveralls bit?
    3. Depending on how we do this we loose a certain amount of paralellization.
    
    I think I'll bubble this up to the ML for more discussion. It seems clear to me that folks
want to do this, but it's just a matter of how. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message