commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <brit...@apache.org>
Subject Re: [PARENT][PROPOSAL] Add Automatic-Module-Name MANIFEST entry
Date Mon, 05 Jun 2017 08:35:36 GMT
Hello Stephen,

> Am 24.05.2017 um 17:11 schrieb Stephen Colebourne <scolebourne@joda.org>:
> 
> On 24 May 2017 at 15:55, Rob Tompkins <chtompki@gmail.com> wrote:
>> We should simply add that entry, "commons.automatic-module-name," to every component
pom’s properties section now, and then when the next parent migration happens, the changes
will express naturally. It might be worth adding a comment on the property in each pom?
>> 
>> I’d be happy to do that between now and Monday.
> 
> As I said upthread, there is an argument to only add it to components
> once they have been checked to see if they are valid for use as a
> module.

Is there some documentation on how to check validity?

Regards,
Benedikt

> 
> That said, I'm willing to go with it as an approach because AFAICT if
> a component isn't a good modular citizen, the Automatic-Module-Name
> MANIFEST entry won't do much harm.
> 
> Of course, strictly speaking we don't know if Automatic-Module-Name
> will be part of the final JDK 9, as private discussions are currently
> ongoing between the key players. Since it will cause no harm if
> wrongly present, I'm OK with this too,
> 
> If you are going to do it, I'd suggest using ${commons.module-name},
> as you will be adding the official module name for the component. That
> it is only used as the automatic module name right now is a detail.
> 
> Stephen
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message