commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From chtompki <...@git.apache.org>
Subject [GitHub] commons-text issue #55: TEXT-97: RandomStringGenerator able to pass multiple...
Date Fri, 07 Jul 2017 12:15:23 GMT
Github user chtompki commented on the issue:

    https://github.com/apache/commons-text/pull/55
  
    @jbduncan has a point here, but the code here does conform to the style of the existing
code. So, I'd lean more towards the changes @ameyjadiye is proposing mainly because to re-work
the code into a static `builder()` method pattern would require changes that would necessitate
a major version change. We could, though, revisit this in the 2.X version if you with @jbduncan.
Thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message