commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kinow <...@git.apache.org>
Subject [GitHub] commons-imaging pull request #30: add-tests
Date Wed, 09 Aug 2017 21:23:31 GMT
Github user kinow commented on a diff in the pull request:

    https://github.com/apache/commons-imaging/pull/30#discussion_r132310660
  
    --- Diff: pom.xml ---
    @@ -209,6 +209,12 @@
           <version>2.5</version>
           <scope>test</scope>
         </dependency>
    +    <dependency>
    --- End diff --
    
    Indeed, and I may even use it in some projects at work. However, other commons components
use - as far as I can remember - JUnit with some local helper classes for tests. So my line
of thinking, is that even though it looks useful, others would have to learn and remember
to use it, or eventually we would end up with calls to Equalsverifier methods, and in some
other places the old way. But again, -0 is not a blocker, if others prefer to have it, I'm
fine with it :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message