commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ajs6f <aj...@apache.org>
Subject Re: [VOTE] Release Apache Commons RDF 0.5.0 based on RC3
Date Thu, 21 Dec 2017 18:56:55 GMT
I have some PRs in now for some of these issues, which I mention merely as reassurance that
they will get looked at.

ajs6f

> On Dec 21, 2017, at 1:45 PM, Jörg Schaible <joerg.schaible@gmx.de> wrote:
> 
> Hi Bruno,
> 
> Am Wed, 13 Dec 2017 09:53:35 +0000 schrieb Bruno P. Kinoshita:
> 
> [snip]
> 
>> I went through the  FindBugs/PMD reports in each module, and found the
>> following warnings:
>> 
>> 
>> * main module:
>>    - Double checked locking is not thread safe in Java. (saw it in
>>    another part, not sure if it's really possibe to fix as we need
>>    cannot create a model twice...)
>> 
>> * commons-df-api:
>>    - Initialization of org.apache.commons.rdf.api.RDFSyntax accesses
>>    class
>> org.apache.commons.rdf.api.W3CRDFSyntax, which isn't initialized yet
>> (this one seems easy to reproduce. Always returns null?)
>> 
>> * commons-rdf-simple:
>>    - org.apache.commons.rdf.simple.DatasetGraphView.unionOrNamedGraph()
>>    has Optional return type and returns explicit null (shouldn't it be
>>    Optional.empty() or something similar?)
>> 
>> 
>> Are any of these blockers? The second one is the only one that if
>> confirmed seems annoying to users.
>> 
>> 
>> Everything looks OK, and I'm OK to vote to release in case others think
>> this release is not actually causing any of these warnings, and that we
>> should release as-is and fix it later.
> 
> Since it it a 0.5 release, we can address that later. So, do you vote?
> 
> Cheers,
> Jörg
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message