commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [VOTE] Release Commons JCS 2.2.1 based on RC3
Date Thu, 14 Dec 2017 00:39:45 GMT
Looking at the release notes, I see junk in the text:

$release.description.replaceAll(" ", "

")

There is also a missing Jira reference for:

o           Unexpected dispose() in CompositeCacheManager.release()
Thanks to athun.

These are not blockers but not very "pro" either :-(

If this vote passes, I expect that the release notes file will be manually
fixed.

Typo in "JCS 2.0 and onwards now targets Java 6.0". The reference to Java
should be "Java 6", not "Java 6.0".

>From the src zip file: ASC, MD5, SHA1 OK.

Running 'mvn clean install' works with:

Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
2017-10-18T01:58:13-06:00) Maven home: C:\Java\apache-maven-3.5.2\bin\..
Java version: 1.7.0_80, vendor: Oracle Corporation Java home: C:\Program
Files\Java\jdk1.7.0_80\jre Default locale: en_US, platform encoding: Cp1252
OS name: "windows 8.1", version: "6.3", arch: "amd64", family: "windows"

I am guessing that all of the .md files need to be regenerated since I see
"<version>2.2</version>" in README.md.

The NOTICE file looks good.

I do not see hard blockers here but there are still details that make this
RC lack polish, so I am +0.

Gary


On Wed, Dec 13, 2017 at 1:02 AM, Romain Manni-Bucau <rmannibucau@gmail.com>
wrote:

> As discussed quite verbosely already I'd like to release JCS 2.2.1. I
> followed the commons procedure this time and hope it works for you.
>
> JCS 2.2.1 RC3 is available for review here:
>     https://dist.apache.org/repos/dist/dev/commons/jcs/ (svn revision
> 23702)
>
> The tag is here:
>
> http://svn.apache.org/repos/asf/commons/proper/jcs/tags/
> commons-jcs-2.2.1-RC3/
> (svn revision 1817933)
>
> Maven artifacts are here:
>     https://repository.apache.org/content/repositories/
> orgapachecommons-1298
>
> I have tested this with JDK 7, 8 using Maven 3.5.0.
>
> Details of changes since 2.2 are in the release notes:
>     https://dist.apache.org/repos/dist/dev/commons/jcs/RELEASE-NOTES.txt
>
> http://home.apache.org/~rmannibucau/commons-jcs-2.2.1-
> RC3/changes-report.html
>
> Site:
>         http://home.apache.org/~rmannibucau/commons-jcs-2.2.1-RC3/
>
> Clirr Report (compared to 2.2):
>
> http://home.apache.org/~rmannibucau/commons-jcs-2.2.1-
> RC3/commons-jcs-core/clirr-report.html
>
> RAT Report:
>
> http://home.apache.org/~rmannibucau/commons-jcs-2.2.1-RC3/rat-report.html
> (the zipcodes.txt file is intended to not have headers)
>
> KEYS:
>   https://www.apache.org/dist/commons/KEYS
>
> Please review the release candidate and vote.
> This vote will close no sooner that 72 hours from now,
> i.e. sometime after 08:15 UTC 16-December 2017
>
>   [ ] +1 Release these artifacts
>   [ ] +-0 Don't care
>   [ ] -1 I oppose this release ${because}
>
> Thanks!
> Romain
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message