commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pascal Schumacher <pascalschumac...@gmx.net>
Subject Re: [text] Adapt the Log4j 2 Interpolator to [text]
Date Tue, 13 Feb 2018 18:06:30 GMT
Am 12.02.2018 um 21:53 schrieb Gary Gregory:
> On Mon, Feb 12, 2018 at 12:53 PM, Gary Gregory <garydgregory@gmail.com>
> wrote:
>
>> On Mon, Feb 12, 2018 at 12:30 PM, Pascal Schumacher <
>> pascalschumacher@gmx.net> wrote:
>>
>>> please revert "Update actual Checkstyle from 6.19 to 8.8.", as Checkstyle
>>> 7+ requries Java 8+.
>>>
>> Done.

Thanks!
>>> and please fix the findbugs violation:
>>>
>>> [INFO] --- findbugs-maven-plugin:3.0.5:check(default-cli)@
>>> commons-text---
>>> [INFO] BugInstance size is 1
>>> [INFO] Error size is 0
>>> [INFO] Total bugs: 1
>>> [INFO] org.apache.commons.text.StringTokenizer.clone() does not call
>>> super.clone() [org.apache.commons.text.StringTokenizer] At
>>> StringTokenizer.java:[lines 1138-1140] CN_IDIOM_NO_SUPER_CALL
>>>
>> But super.clone() is called, from another method...
>>
> And findbugs does not complain about the same code in StrTokenizer. What?

For StrTokenizer there is an exclusion in fb-excludes.xml.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message