commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Claude Warren <cla...@xenei.com>
Subject Re: [collections] breaking changes
Date Thu, 29 Mar 2018 15:03:25 GMT
if we are using semantic numbering would this not cause a major revision
change as older code will no longer function?

Claude

On Thu, Mar 29, 2018 at 3:51 PM, Gary Gregory <garydgregory@gmail.com>
wrote:

> Hi All:
>
> Updating Commons Collections' commons-parent from version 43 to 45 causes
> the build to fail due to the use of japicmp which reports:
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.7:site (default-site) on
> project commons-collections4: Error generating
> japicmp-maven-plugin:0.11.0:cmp-report report: Failed to generate report:
> Breaking the build because there is at least one incompatibility:
> org.apache.commons.collections4.IteratorUtils.peekingIterator(java.util.
> Iterator):METHOD_RETURN_TYPE_CHANGED,org.apache.commons.
> collections4.IteratorUtils.pushbackIterator(java.util.
> Iterator):METHOD_RETURN_TYPE_CHANGED
> -> [Help 1]
>
> This is caused by:
>
> - [COLLECTIONS-676] Modify IteratorUtils.pushbackIterator signature to
> return PushbackIterator.
> - [COLLECTIONS-675] Modify IteratorUtils.peekingIterator signature to
> return PeekingIterator.
>
> Which are reasonable changes IMO.
>
> Does anyone object to these changes and adding exceptions to allow japicmp
> to
> not fail the build?
>
> Thank you,
> Gary
>



-- 
I like: Like Like - The likeliest place on the web
<http://like-like.xenei.com>
LinkedIn: http://www.linkedin.com/in/claudewarren

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message