commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sfuhrm <...@git.apache.org>
Subject [GitHub] commons-cli issue #25: CLI-284: Fix inconsistent behaviour for short and lon...
Date Sun, 10 Jun 2018 12:05:37 GMT
Github user sfuhrm commented on the issue:

    https://github.com/apache/commons-cli/pull/25
  
    Hi @kinow 
    
    thanks for your review! Oops, my maven build had a hickup and all tests were green.
    
    There's a design problem in the code you pointed me to. Every Option instance may be illegal
(short and long == null) until first use. OptionBuilder (line 356) insists on creating an
Option instance even if he long parameter is missing. Option.Builder does something similar.
    The setting happens after Option instance construction.



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message