commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rob Tompkins <chtom...@gmail.com>
Subject Re: [rng] commons-rng-jmh module?
Date Fri, 13 Jul 2018 19:07:30 GMT
I just pulled your user guide changes in to my 1.1 branch. Will that cover it?

> On Jul 12, 2018, at 8:18 AM, Gilles <gilles@harfang.homelinux.org> wrote:
> 
> On Wed, 11 Jul 2018 20:16:26 -0400, Rob Tompkins wrote:
>>> On Jul 11, 2018, at 7:05 PM, Gilles <gilles@harfang.homelinux.org> wrote:
>>> 
>>> On Wed, 11 Jul 2018 12:54:56 -0400, Rob Tompkins wrote:
>>>> Also isn’t removing a module a bc - incompatible change?
>>> 
>>> The benchmarking code is/was not part of the functionality.
>>> 
>>>>> On Jul 11, 2018, at 12:42 PM, Rob Tompkins <chtompki@gmail.com>
wrote:
>>>>> 
>>>>> In my prepping for the release I’ve run across references for “commons-rng-jmh.”
>>> 
>>> Where?
>>> 
>>>>> Does this module exist anymore?
>>> 
>>> It was replaced by "commons-rng-examples/examples-jmh"
>>> 
>>>>> Is it generated code??
>>> 
>>> No. [Although running "mvn test" does generate code (by JMH).]
>>> 
>>>>> Can I leave it out?
>>> 
>>> As per the above, the module does not exist in v1.1.
>>> 
>>> Best regards,
>>> Gilles
>> 
>> Gotcha. Guess it’s cruft left behind.
> 
> I found the reference in the userguide; it's hopefully fixed in
> branch "1.1" (commit b89752b836ac259daeeace92b2dee47d56482ac2)
> but I could not test it as "mvn site" fails, with a stacktrace
> that refers to "FindBugs" (since it should have been replaced
> by "SpotBugs" I don't get why this happens).
> 
> The commit should be ported to "master".
> 
> Gilles
> 
>> 
>>> 
>>>>> 
>>>>> -Rob
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message