commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles <gil...@harfang.homelinux.org>
Subject Re: [rng] packaging (Was: Re: [VOTE] Release Apache Commons RNG 1.1 based on RC2)
Date Fri, 20 Jul 2018 15:03:19 GMT
On Fri, 20 Jul 2018 08:54:52 -0600, Gary Gregory wrote:
> Is the VOTE still in progress or are you guys debating whether or not 
> to
> cancel  it?

Whether you can run:
  $ mvn package install -Pcommons-rng-examples
would be a second data point towards that decision. :-)

Gilles

> Gary
>
> On Fri, Jul 20, 2018 at 8:46 AM Gilles <gilles@harfang.homelinux.org> 
> wrote:
>
>> On Fri, 20 Jul 2018 09:38:51 -0400, Rob Tompkins wrote:
>> >> On Jul 20, 2018, at 9:26 AM, Gilles 
>> <gilles@harfang.homelinux.org>
>> >> wrote:
>> >>
>> >> Hello.
>> >>
>> >> On Fri, 20 Jul 2018 08:59:05 -0400, Rob Tompkins wrote:
>> >>>> On Jul 19, 2018, at 8:58 PM, Gilles 
>> <gilles@harfang.homelinux.org>
>> >>>> wrote:
>> >>>>
>> >>>> Hi.
>> >>>>
>> >>>> On Thu, 19 Jul 2018 15:21:28 -0400, Rob Tompkins wrote:
>> >>>>> We have added some significant enhancements since Apache 
>> Commons
>> >>>>> RNG
>> >>>>> 1.0 was released, so I would like to release Apache Commons

>> RNG
>> >>>>> 1.1.
>> >>>>>
>> >>>>> Apache Commons RNG (full distribution) 1.1 RC2 is available

>> for
>> >>>>> review here:
>> >>>>>   https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC2
>> >>>>> <https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC2>

>> (svn
>> >>>>> revision 28231)
>> >>>>
>> >>>> "commons-rng-1.1-bin.zip" and "commons-rng-1.1-bin.tar.gz": 
>> Thank
>> >>>> you!
>> >>>>
>> >>>> Is module "dist-archive" now redundant (to be removed)?  [Or 
>> are
>> >>>> the
>> >>>> above files still generated from it?]
>> >>>
>> >>> I’m still using it.
>> >>
>> >> Oh; I thought that it worked the way it is supposed to (IMHO). 
>> :-{
>> >
>> > It does, I don’t have to cd into the project to get the dist files 
>> to
>> > go up to svn; the “mvn … deploy” command works from the root of 
>> the
>> > project.
>> >
>> >>
>> >>>>
>> >>>>> The Git tag RNG_1_1_RC2 commit for this RC is here:
>> >>>>> 'git <command> [<revision>...] -- [<file>...]'
which you can
>> >>>>> browse here:
>> >>>>>
>> >>>>>
>> >>>>>
>> 
>> https://git-wip-us.apache.org/repos/asf?p=commons-rng.git;a=tag;h=refs/tags/RNG_1_1_RC2
>> >>>>>
>> >>>>> Maven artifacts are here:
>> >>>>>
>> >>>>>
>> >>>>>
>> 
>> https://repository.apache.org/content/repositories/orgapachecommons-1352/org/apache/commons/
>> >>>>>
>> >>>>> These are the Maven artifacts and their hashes in Nexus:
>> >>>>>
>> >>>>> #Nexus artifact SHA-1s
>> >>>>> SHA1(commons-rng-client-api-1.1-javadoc.jar)=
>> >>>>> 6b00830cab08147e504766a17328a27a95cea712
>> >>>>> SHA1(commons-rng-client-api-1.1-sources.jar)=
>> >>>>> 2abac2aad66a600dccd261749e9e700bc55edf89
>> >>>>> SHA1(commons-rng-client-api-1.1-test-sources.jar)=
>> >>>>> a477215706b68a2c45fc96df5f60ff7988056365
>> >>>>> SHA1(commons-rng-client-api-1.1-tests.jar)=
>> >>>>> 43af258c73539543d18f96cfea75c2564286f18e
>> >>>>> SHA1(commons-rng-client-api-1.1.jar)=
>> >>>>> 71eb6ac796d2bfc6d6d2330d08b46b8998297982
>> >>>>> SHA1(commons-rng-client-api-1.1.pom)=
>> >>>>> 26ec84056b9a4526bc5e05ecf4ece8d9c3d57aad
>> >>>>> SHA1(commons-rng-core-1.1-javadoc.jar)=
>> >>>>> 6a98949fcfc1f490e30af49017bcc2868f716da5
>> >>>>> SHA1(commons-rng-core-1.1-sources.jar)=
>> >>>>> 6b55d976271ae7ad79ded90e32b8575e40e01bfc
>> >>>>> SHA1(commons-rng-core-1.1-test-sources.jar)=
>> >>>>> 8c03d8b90594a6655903541f0b477f8e3ba8c343
>> >>>>> SHA1(commons-rng-core-1.1-tests.jar)=
>> >>>>> 9f747af9b20c8c4d70647df38a4323750a0f5800
>> >>>>> SHA1(commons-rng-core-1.1.jar)=
>> >>>>> a4b491d5bbe0d398e4453d4bd0255eb1e707e3c9
>> >>>>> SHA1(commons-rng-core-1.1.pom)=
>> >>>>> 196e691038f3eb7eb3a45693315b9ca1e4d73e90
>> >>>>> SHA1(commons-rng-parent-1.1-site.xml)=
>> >>>>> 6e1df36b720e14eed524396107481e509ff42c7c
>> >>>>> SHA1(commons-rng-parent-1.1.pom)=
>> >>>>> 456203f8707d9f6a927cab51713e078eef126db2
>> >>>>> SHA1(commons-rng-sampling-1.1-javadoc.jar)=
>> >>>>> 807d78c8fcaab16818d96fd3b8984c7bbe777f31
>> >>>>> SHA1(commons-rng-sampling-1.1-sources.jar)=
>> >>>>> d94f4f1b64a40e874e324388eb67936b51eae34c
>> >>>>> SHA1(commons-rng-sampling-1.1-test-sources.jar)=
>> >>>>> b6c62a0c37687906f3d97b9871e8399577805974
>> >>>>> SHA1(commons-rng-sampling-1.1-tests.jar)=
>> >>>>> fe25a8b485d0e7fb782154a60ccc89ed528220c1
>> >>>>> SHA1(commons-rng-sampling-1.1.jar)=
>> >>>>> 2a3b034bcc688b444839ed268307e0870b70e38b
>> >>>>> SHA1(commons-rng-sampling-1.1.pom)=
>> >>>>> 6321863616bf687731d2c3d28fe6ec9c9f340e90
>> >>>>> SHA1(commons-rng-simple-1.1-javadoc.jar)=
>> >>>>> d1f10e032078ab73f202cac2aa90fb7e80cf5d4a
>> >>>>> SHA1(commons-rng-simple-1.1-sources.jar)=
>> >>>>> 285ceca8976a89525c484f7656b75e87615653e3
>> >>>>> SHA1(commons-rng-simple-1.1-test-sources.jar)=
>> >>>>> 35b32201d34a4724cc77c3584e3a0bb0de74210d
>> >>>>> SHA1(commons-rng-simple-1.1-tests.jar)=
>> >>>>> e5181be4b4314bcea56376234ca962f63c6682b6
>> >>>>> SHA1(commons-rng-simple-1.1.jar)=
>> >>>>> 3b3cee5833c37eef68b2e976727ad786cf0666f8
>> >>>>> SHA1(commons-rng-simple-1.1.pom)=
>> >>>>> a3f7a09914ba4b7dfc2a28fec5d7a40f3f1ea962
>> >>>>>
>> >>>>> #Release SHA-1s
>> >>>>> #Thu Jul 19 12:47:04 EDT 2018
>> >>>>>
>> >>>>>
>> 
>> commons-rng-1.1-bin-tar.gz.asc=c3f836de906655a83a8e2a3728393378829f2116
>> >>>>> 
>> commons-rng-1.1-src-zip=e667b1b7f1409dbdc809f0aeeeabb0bc48bef331
>> >>>>> 
>> commons-rng-1.1-pom.asc=ff1f921acebd92ce1cab7d63a60cfcf0498da77a
>> >>>>> 
>> commons-rng-1.1-bin-zip=ea19ddac066eead6d8230e3508a084491fd9e2e0
>> >>>>>
>> >>>>> 
>> commons-rng-1.1-src-tar.gz=e89aa1f0146f06f09380ff5ef59447164b9b7d93
>> >>>>>
>> >>>>> 
>> commons-rng-1.1-src-zip.asc=1c90762097b9d352c68cfd0efffef57921a819ce
>> >>>>>
>> >>>>> 
>> commons-rng-1.1-bin-tar.gz=669805ba1e42a0b04f6e4967884e29d408b98cff
>> >>>>>
>> >>>>>
>> 
>> commons-rng-1.1-src-tar.gz.asc=b20bc2a58a2a67cf76b9bf3c8a2f091dc947f54a
>> >>>>>
>> >>>>> 
>> commons-rng-1.1-bin-zip.asc=3eaaa305fdd1a673b0bb1a4bcb8b4bf9a521ac39
>> >>>>>
>> >>>>> #Release SHA-256s
>> >>>>> #Thu Jul 19 12:47:04 EDT 2018
>> >>>>>
>> >>>>>
>> 
>> commons-rng-1.1-bin-tar.gz.asc=12cc7d1b7fc19004a2ae5aac4e366c76651b595dbc124e34d22012b672faa24e
>> >>>>>
>> >>>>>
>> 
>> commons-rng-1.1-src-zip=a1a4c9e4653dbf0af3f71d97267b71c19065f39cc8fe303a7cd6183e3e755326
>> >>>>>
>> >>>>>
>> 
>> commons-rng-1.1-pom.asc=4fdf05e582fa428f473c0d5aedbce4d1b5cd0d494706d3ae050d06d8631e0776
>> >>>>>
>> >>>>>
>> 
>> commons-rng-1.1-bin-zip=53e855362d9a62b5963525f514647169395f13b12febc0619ec3087915ff3b09
>> >>>>>
>> >>>>>
>> 
>> commons-rng-1.1-src-tar.gz=f23e07e04197777fbdf13fd35154f81efc79f09f3f935f82a310c59003c5f2c1
>> >>>>>
>> >>>>>
>> 
>> commons-rng-1.1-src-zip.asc=ca5b76e06336d366a79b05f3ebdf947f42c82bad0964bd87cf04302a206ec975
>> >>>>>
>> >>>>>
>> 
>> commons-rng-1.1-bin-tar.gz=eb743f551b14de9fc7926c33d43a572aa488e3b74c79f15be71907e21f344931
>> >>>>>
>> >>>>>
>> 
>> commons-rng-1.1-src-tar.gz.asc=1cc42fd0d98cd74ce69c7feb1019f6b33bd548317563de0076237ab826bb4288
>> >>>>>
>> >>>>>
>> 
>> commons-rng-1.1-bin-zip.asc=3a836f7a7fe9e72b443692835dd83735031524671885504440b0ecb0a36b48e0
>> >>>>>
>> >>>>>
>> >>>>> (no need for .asc hashes!)
>> >>>>>
>> >>>>> I have tested this with mvn clean install site' using:
>> >>>>> Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
>> >>>>> 2018-06-17T14:33:14-04:00)
>> >>>>> Maven home: /usr/local/Cellar/maven/3.5.4/libexec
>> >>>>> Java version: 1.8.0_172, vendor: Oracle Corporation, runtime:
>> >>>>>
>> >>>>> 
>> /Library/Java/JavaVirtualMachines/jdk1.8.0_172.jdk/Contents/Home/jre
>> >>>>> Default locale: en_US, platform encoding: UTF-8
>> >>>>> OS name: "mac os x", version: "10.13.6", arch: "x86_64", 
>> family:
>> >>>>> "mac"
>> >>>>>
>> >>>>>
>> >>>>> Details of changes since 1.0 are in the release notes:
>> >>>>>
>> >>>>>
>> >>>>>
>> 
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC2/RELEASE-NOTES.txt
>> >>>>>
>> >>>>>
>> >>>>>
>> 
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC2/site/changes-report.html
>> >>>>>
>> >>>>> Site:
>> >>>>>   
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC2/site
>> >>>>>   (note some *relative* links are broken and the 1.1 
>> directories
>> >>>>> are not yet created - these will be OK once the site is
>> >>>>> deployed.)
>> >>>>>
>> >>>>> CLIRR Report (compared to 1.0):
>> >>>>>
>> >>>>>
>> >>>>>
>> 
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC2/site/clirr-report.html
>> >>>>
>> >>>> Server returns:
>> >>>> ---
>> >>>> Not Found
>> >>>>
>> >>>> The requested URL
>> >>>> /repos/dist/dev/commons/rng/1.1-RC2/site/clirr-report.html was 
>> not
>> >>>> found on this server.
>> >>>
>> >>> Ok….no worries there.
>> >>
>> >> Then perhaps that the auto-generated message should leave it out
>> >> (let the people decide what to check if the hints lead to nowhere
>> >> :-).
>> >>
>> >>>> ---
>> >>>>
>> >>>> Submodules have the reports:
>> >>>>
>> >>>>
>> 
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC2/site/commons-rng-simple/clirr-report.html
>> >>>> <
>> 
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC2/site/commons-rng-simple/clirr-report.html
>> >
>> >>>>
>> >>>>
>> 
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC2/site/commons-rng-sampling/clirr-report.html
>> >>>> <
>> 
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC2/site/commons-rng-sampling/clirr-report.html
>> >
>> >>>> etc.
>> >>>>
>> >>>> Hence, I'd suggest to either remove that line from this 
>> message,
>> >>>> or
>> >>>> to generate links to each of the submodules.
>> >>>>
>> >>>>>
>> >>>>> JApiCmp Report (compared to 1.0):
>> >>>>>
>> >>>>>
>> >>>>>
>> 
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC2/site/japicmp.html
>> >>>>> <
>> 
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC2/site/japicmp.html
>> >
>> >>>>
>> >>>> Empty (and empty for all submodules).
>> >>>> Hence, I'd suggest to remove this line (or to mention that 
>> Japicmp
>> >>>> was disabled).
>> >>>
>> >>> Can’t remove it from the site, except manually because of the 
>> way
>> >>> the
>> >>> plugin works (arg).
>> >>
>> >> Same as above comment.
>> >>
>> >>>>
>> >>>>>
>> >>>>> RAT Report: (Note. All of the Unknown Licenses are under 
>> "target"
>> >>>>> or
>> >>>>> "site-content". Please verify rat with local build.)
>> >>>>>
>> >>>>>
>> >>>>>
>> 
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC2/site/rat-report.html
>> >>>>> <
>> 
>> https://dist.apache.org/repos/dist/dev/commons/rng/1.1-RC2/site/rat-report.html
>> >
>> >>>>
>> >>>> All submodules seem to provide a correct report.
>> >>>> Thus, the top-level rat report should not exist at all, like 
>> for
>> >>>> Clirr.
>> >>>> [As is, it hogs the browser trying to load a bogus list of
>> >>>> non-compliant
>> >>>> files.]
>> >>>
>> >>> Maybe I’ll get rid of the aggregate child bit.
>> >>
>> >> For sure.
>> >>
>> >>>>
>> >>>>>
>> >>>>> KEYS:
>> >>>>> https://www.apache.org/dist/commons/KEYS
>> >>>>> <https://www.apache.org/dist/commons/KEYS>
>> >>>>>
>> >>>>> Please review the release candidate and vote.
>> >>>>
>> >>>> Running
>> >>>> $ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64 mvn clean package
>> >>>> install -Pcommons-rng-examples site site:stage
>> >>>> I get the following failure:
>> >>>> ---
>> >>>> [ERROR] Failed to execute goal on project commons-rng: Could 
>> not
>> >>>> resolve dependencies for project
>> >>>> org.apache.commons:commons-rng:pom:1.1: The following artifacts
>> >>>> could not be resolved:
>> >>>> 
>> org.apache.commons:commons-rng-examples-jpms-app:jar:javadoc:1.1,
>> >>>> 
>> org.apache.commons:commons-rng-examples-jpms-lib:jar:javadoc:1.1:
>> >>>> Failure to find
>> >>>> 
>> org.apache.commons:commons-rng-examples-jpms-app:jar:javadoc:1.1 in
>> >>>> https://repo.maven.apache.org/maven2
>> >>>> <https://repo.maven.apache.org/maven2> was cached in the local
>> >>>> repository, resolution will not be reattempted until the update
>> >>>> interval of central has elapsed or updates are forced
>> >>>> —
>> >>>
>> >>> Curious. Do you have any thoughts here? Are those supposed to be
>> >>> published to nexus?
>> >>
>> >> Not sure what you mean.
>> >> The issue is that I can't build the project from source.
>> >
>> > Curious. Had you run a "mvn clean install" before running that?
>>
>> I've run
>>   $ JAVA_HOME=/usr/lib/jvm/java-9-openjdk-amd64 mvn
>> -Pcommons-rng-examples clean install package site site:stage
>>
>> > It’s
>> > as if that maven profile doesn’t effectively install the requisite
>> > dependencies before looking for them in  building the example
>> > project.
>>
>> Looking more closely, I now notice that it seems to look for
>> the *javadoc* JARs of the
>>    commons-rng-examples-jpms-app
>>    commons-rng-examples-jpms-lib
>> modules.
>>
>> Hope this helps figuring out what could be missing from the process.
>>
>> Gilles
>>
>> > What’s the right thing to do here? I’m going to fiddle around with
>> > the
>> > packaged source without 1.1 in my ~/.m2/repository directory.
>> >
>> >>
>> >>> You think I should [CANCEL] and roll and RC3 with
>> >>> the aforementioned changes?
>> >>
>> >> Fixing the RAT fake report would be nice.
>> >> Getting to build from source seems quite necessary to vote
>> >> positively. :-)
>> >>
>> >> Best,
>> >> Gilles
>> >>
>> >>> -Rob
>> >>>
>> >>>>
>> >>>> Regards,
>> >>>> Gilles
>> >>>>
>> >>>>> This vote will close no sooner that 72 hours from now.
>> >>>>>
>> >>>>> [ ] +1 Release these artifacts
>> >>>>> [ ] +0 OK, but...
>> >>>>> [ ] -0 OK, but really should fix...
>> >>>>> [ ] -1 I oppose this release because...
>> >>>>>
>> >>>>> Thank you,
>> >>>>>
>> >>>>> Rob Tompkins,
>> >>>>> Release Manager (using key
>> >>>>> B6E73D84EA4FCC47166087253FAAD2CD5ECBB314)
>> >>>>
>> >>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message