commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles <gil...@harfang.homelinux.org>
Subject Re: [rng] animal sniffer java target?
Date Tue, 10 Jul 2018 23:38:45 GMT
On Tue, 10 Jul 2018 15:22:39 -0600, Gary Gregory wrote:
> On Tue, Jul 10, 2018 at 2:46 PM Rob Tompkins <chtompki@gmail.com> 
> wrote:
>
>>
>>
>> > On Jul 10, 2018, at 4:42 PM, Gary Gregory <garydgregory@gmail.com>
>> wrote:
>> >
>> > On Tue, Jul 10, 2018 at 2:40 PM Rob Tompkins <chtompki@gmail.com
>> <mailto:chtompki@gmail.com>> wrote:
>> >
>> >>
>> >>
>> >>> On Jul 10, 2018, at 4:13 PM, Gilles 
>> <gilles@harfang.homelinux.org>
>> >> wrote:
>> >>>
>> >>> On Tue, 10 Jul 2018 15:57:24 -0400, Rob Tompkins wrote:
>> >>>> I’ve gotten through most of the build except that I get animal
>> >>>> sniffer errors depending on what target version I choose. Below
>> >>>> maven.compiler.target I’ve added:
>> >>>>
>> >>>> <javaTarget.majorVersion>1</javaTarget.majorVersion>
>> >>>> <javaTarget.minorVersion>8</javaTarget.minorVersion>
>> >>>>
>> >>>> to try to get the animal sniffer to behave, but it still yields
>> >>>> errors. @Gilles - thoughts?
>> >>>
>> >>> The component provides functionality that can be used with Java 
>> 6+.
>> >>> All modules except "commons-rng-examples" are Java 6 compatible.
>> >>> Some sub-modules of "commons-rng-examples" require a more recent
>> >>> JDK (and the default target is Java 8).
>> >>> Module "commons-rng-examples/examples-jpms" requires Java 9, as 
>> it
>> >>> tests JPMS. [The "maven.compiler.target" is set accordingly in 
>> the
>> >>> POM.]
>> >>> By which tool are the
>> >>> javaTarget.majorVersion
>> >>> and
>> >>> javaTarget.minorVersion
>> >>> variables required?
>> >>> Where are they set?
>> >>
>> >> Do you care if the animal-sniffer-plugin is run on this 
>> sub-project?
>> >> Somehow, setting the source and target variables set up 
>> animal-sniffer
>> to
>> >> download the signature artifact 
>> "org.codehaus.mojo.signature:java90:1.0”
>> >> which isn’t in maven central. We can either set animal-sniffer to 
>> a
>> >> specific java version or avoid it all together on that 
>> subproject. What
>> do
>> >> you want to do?
>> >>
>> >
>> > If you build we Java 9, you can use the "-release" option, but it 
>> seems
>> we
>> > are a ways from that…
>>
>> I am running in -Prelease mode with java 9 with all of this. My run 
>> is
>> "mvn -Dcommons.release.dryRun=true -Ptest-deploy -Prelease
>> -Pcommons-rng-examples clean test site deploy"
>>
>
> Sorry, I was talking about using the --release option on the Java 
> compiler
> instead of the animal-sniffer plugin.

Isn't it what maven does when setting
  maven.compiler.target
?

Otherwise, I'm fine with dropping animal-sniffer and wait
for bug reports if the Java 6 promise is broken. ;-)

Gilles


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message