commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From george-ranjan <...@git.apache.org>
Subject [GitHub] commons-collections pull request #55: COLLECTIONS-697 Added relevant JavaDoc...
Date Tue, 02 Oct 2018 17:48:36 GMT
GitHub user george-ranjan opened a pull request:

    https://github.com/apache/commons-collections/pull/55

    COLLECTIONS-697 Added relevant JavaDoc and a test which proves

    I just noticed that it is not explicitly mentioned in the JavaDoc that modifying the underlying
list of a FixedSizeList would actually land up modifying the list of the constructed FixedSizeList.
Not sure if this was by design, but at the very list I think the JavaDoc should caution against
this.
    
    This Pull Request has the necessary updates to the JavaDoc and a test that proves the
findings.
    
    NOTE: this is my first PR and I have tried to follow the guidelines.  Pleas let me know
if I need to do anything more.  Thanks!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/george-ranjan/commons-collections COLLECTIONS-697_FixedSizeList

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-collections/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #55
    
----
commit 1517ed304eef7737b7175a997d77cca384be8631
Author: george-ranjan <george.ranjan@...>
Date:   2018-10-02T17:44:07Z

    COLLECTIONS-697 Added relevant JavaDoc and a test which proves

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message