commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Herbert <alex.d.herb...@gmail.com>
Subject Re: [Rng] New XoShiRo generators
Date Wed, 06 Mar 2019 20:38:28 GMT


> On 6 Mar 2019, at 17:13, Gilles Sadowski <gilleseran@gmail.com> wrote:
> 
> Le mer. 6 mars 2019 à 16:50, Alex Herbert <alex.d.herbert@gmail.com> a écrit
:
>> 
>> I would like to merge this PR introducing the new XoShiRo generators:
>> 
>> https://github.com/apache/commons-rng/pull/20 <https://github.com/apache/commons-rng/pull/20>
>> 
>> Can I get a review to check that nothing is obviously bad.
> 
> In the PR, you mention:
>> Further changes to the other projects to add the extra providers will be required
when accepted.
> 
> What changes are you referring to?

I have not yet updated the benchmarking examples to add the new generators. I was going to
add them later. Should I do this in the PR too?

I plan to squash all the changes in the current PR to clean it up and move the updated XorShift1024StarPhi
to different PR.

> 
> Gilles
> 
>> 
>> Thanks,
>> 
>> Alex
>> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message