commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilles Sadowski <gillese...@gmail.com>
Subject Re: [Rng] New XoShiRo generators
Date Wed, 06 Mar 2019 17:11:24 GMT
Le mer. 6 mars 2019 à 17:27, Alex Herbert <alex.d.herbert@gmail.com> a écrit :
>
>
>
> > On 6 Mar 2019, at 16:22, Gilles Sadowski <gilleseran@gmail.com> wrote:
> >
> > Hi Alex.
> >
> > Le mer. 6 mars 2019 à 16:50, Alex Herbert <alex.d.herbert@gmail.com> a écrit
:
> >>
> >> I would like to merge this PR introducing the new XoShiRo generators:
> >>
> >> https://github.com/apache/commons-rng/pull/20 <https://github.com/apache/commons-rng/pull/20>
> >>
> >> Can I get a review to check that nothing is obviously bad.
> >
> > * Can we indeed have separate PR/commits for the change/fix of the existing
> >  "XorShift1024Star" and its improved version?
>
> I’ll move this to a new Jira and PR.
>
> Should we mark the old enum value XOR_SHIFT_1024_S as deprecated? You had previously
mentioned that. The algorithm is not really broken. It has just been made better so I was
thinking no.

Do the two variants produce uncorrelated sequences?

>
> > * Is it possible for the abstract classes to be package-private?
> >  [I've just noticed that "AbstractWell" should have been made so too.]
>
> OK.
>

Thanks,
Gilles

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message