commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Otto Fowler <ottobackwa...@gmail.com>
Subject Re: [Parent] RAT check
Date Tue, 12 Mar 2019 14:28:44 GMT
Maybe put it in a profile, and you can document that that profile will be
used to check _and_ run that profile for the travis builds, such that a
failed travis build will show that the pr is invalid.


On March 12, 2019 at 09:39:44, Gary Gregory (garydgregory@gmail.com) wrote:

On Mon, Mar 11, 2019 at 4:59 PM Jochen Wiedmann <jochen.wiedmann@gmail.com>
wrote:

> On Mon, Mar 11, 2019 at 5:58 PM Gary Gregory <garydgregory@gmail.com>
> wrote:
>
> > The idea, for me, is that a contributor should not be able to test and
> > submit a PR with a failing RAT check.
>
> If so, then I'd suggest a server-side Git hook for that.
>

I do not like this idea because I want to know BEFORE I commit or propose a
PR that something is wrong.

Gary

>
> Jochen
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message