commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Herbert <alex.d.herb...@gmail.com>
Subject Re: [commons-codec] branch master updated: Javadoc tweaks.
Date Mon, 06 May 2019 05:54:30 GMT
All comments indicate that the bit raised is index 0. This should be updated for each constant
to use the appropriate index from 0-7:

Mask with bit zero-based index [0-7] raised.


> On 5 May 2019, at 22:21, ggregory@apache.org wrote:
> 
> This is an automated email from the ASF dual-hosted git repository.
> 
> ggregory pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/commons-codec.git
> 
> 
> The following commit(s) were added to refs/heads/master by this push:
>     new 04d9492  Javadoc tweaks.
> 04d9492 is described below
> 
> commit 04d9492912de085abf6fe176b79b7e6d923a529a
> Author: Gary Gregory <gardgregory@gmail.com>
> AuthorDate: Sun May 5 17:21:49 2019 -0400
> 
>    Javadoc tweaks.
> ---
> .../apache/commons/codec/binary/BinaryCodecTest.java   | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/src/test/java/org/apache/commons/codec/binary/BinaryCodecTest.java b/src/test/java/org/apache/commons/codec/binary/BinaryCodecTest.java
> index d7b994c..ceee367 100644
> --- a/src/test/java/org/apache/commons/codec/binary/BinaryCodecTest.java
> +++ b/src/test/java/org/apache/commons/codec/binary/BinaryCodecTest.java
> @@ -38,31 +38,31 @@ public class BinaryCodecTest {
> 
>     private static final Charset CHARSET_UTF8 = Charsets.UTF_8;
> 
> -    /** mask with bit zero based index 0 raised */
> +    /** Mask with bit zero-based index 0 raised. */
>     private static final int BIT_0 = 0x01;
> 
> -    /** mask with bit zero based index 0 raised */
> +    /** Mask with bit zero-based index 0 raised. */
>     private static final int BIT_1 = 0x02;
> 
> -    /** mask with bit zero based index 0 raised */
> +    /** Mask with bit zero-based index 0 raised. */
>     private static final int BIT_2 = 0x04;
> 
> -    /** mask with bit zero based index 0 raised */
> +    /** Mask with bit zero-based index 0 raised. */
>     private static final int BIT_3 = 0x08;
> 
> -    /** mask with bit zero based index 0 raised */
> +    /** Mask with bit zero-based index 0 raised. */
>     private static final int BIT_4 = 0x10;
> 
> -    /** mask with bit zero based index 0 raised */
> +    /** Mask with bit zero-based index 0 raised. */
>     private static final int BIT_5 = 0x20;
> 
> -    /** mask with bit zero based index 0 raised */
> +    /** Mask with bit zero-based index 0 raised. */
>     private static final int BIT_6 = 0x40;
> 
> -    /** mask with bit zero based index 0 raised */
> +    /** Mask with bit zero-based index 0 raised. */
>     private static final int BIT_7 = 0x80;
> 
> -    /** an instance of the binary codec */
> +    /** An instance of the binary codec. */
>     BinaryCodec instance = null;
> 
>     @Before
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message