commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Herbert <alex.d.herb...@gmail.com>
Subject [rng] binary compatibility with final modifier
Date Thu, 23 May 2019 11:43:02 GMT
[rng] has three classes with a private constructor that are not 
currently marked as final. 1 is public and 2 are package private.

If I mark them as final then clirr:check ignores the package private 
ones and produces this warning for the public one:

"Added final modifier to class, but class was effectively final anyway"


Given the class could not have been extended (due to a private 
constructor) it seems OK to allow the final modifier.

So can the final modifier be added? Is there a precedent here with 
regard to releases?


Alex



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message