commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [io] NIO2 and non-default file system support
Date Thu, 16 May 2019 10:37:08 GMT
The one patch has been merged.

Gary

On Thu, May 16, 2019, 02:03 Matt Sicker <boards@gmail.com> wrote:

> I’ve been interested in seeing IO be updated to include support for using
> Path instead of just File. I can review your PR this week, though I’m
> certainly not the only one who can.
>
> On Tue, May 14, 2019 at 13:19, Chesney, Mark <Mark.Chesney@insight.com>
> wrote:
>
> > Hello,
> >
> > Awhile back I ran into a situation where I needed to read the lines of a
> > file that might be on a non-default file system, like an in-memory file
> > system, on Java 7+. I looked to the commons-io ReversedLinesFileReader,
> but
> > it only works with java.io.File files which are always on the default
> file
> > system only. I duplicated the class in my project and found it was
> > relatively straightforward to adapt it to support both java.io.File and
> > java.nio.file.Path file. Commons-io 2.6 seems to be the first version to
> > require Java 7 which introduced NIO2. I think others would appreciate the
> > NIO2 constructors, saving a call to Path#toFile(), even if they're not
> > using non-default file systems. I previously created a JIRA issue IO-578<
> > https://issues.apache.org/jira/browse/IO-578> and an GitHub pull request
> > #62<https://github.com/apache/commons-io/pull/62>. I feel the PR is of
> > very high quality, short and to the point, ready or nearly ready to
> merge.
> > I would appreciate any feedback I can get on the JIRA issue or GitHub PR.
> > I'm hopeful this could make commons-io 2.7. Thanks for your attention and
> > consideration.
> >
> >
> >
> > Regards,
> >
> > Mark
> >
> --
> Matt Sicker <boards@gmail.com>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message