commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Herbert <alex.d.herb...@gmail.com>
Subject Re: [commons-statistics] branch master updated: should we leave the travis build broken as incentive to clean things up?
Date Mon, 20 May 2019 12:01:28 GMT
On 19/05/2019 03:20, chtompki@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> chtompki pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/commons-statistics.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>       new be238b9  should we leave the travis build broken as incentive to clean things
up?
> be238b9 is described below
>
> commit be238b93961fd5ce177a07704a6076620c99d6c7
> Author: Rob Tompkins <chtompki@gmail.com>
> AuthorDate: Sat May 18 22:20:12 2019 -0400
>
>      should we leave the travis build broken as incentive to clean things up?

I fixed this since PRs from the [gsoc] mentees are now being run through 
travis and should work to avoid a lot of extra code inspection.

I've updated the config for findbugs to spotbugs based on what [rng] was 
using. This then required some excludes to the spotbugs-filter.xml for 
three cases of floating point equality checks.

I changed pmd:pmd to pmd:check. This is OK.

I fixed checkstyle for all the test sources an upgraded to a newer 
version of checkstyle.

The default Maven goal now builds.

> ---
>   pom.xml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/pom.xml b/pom.xml
> index f46b242..d4b50a3 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -176,7 +176,7 @@
>     </dependencies>
>   
>     <build>
> -    <defaultGoal>clean test</defaultGoal>
> +    <defaultGoal>clean verify apache-rat:check clirr:check checkstyle:check pmd:pmd
spotbugs:check javadoc:javadoc</defaultGoal>
>       <plugins>
>         <plugin>
>           <groupId>org.apache.maven.plugins</groupId>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message