commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Herbert <alex.d.herb...@gmail.com>
Subject Re: [VOTE] Release Apache Commons CSV 1.7 based on RC1
Date Mon, 03 Jun 2019 19:49:11 GMT


> On 3 Jun 2019, at 18:47, Alex Herbert <alex.d.herbert@gmail.com> wrote:
> 
> 
> 
>> On 3 Jun 2019, at 15:11, Gary Gregory <garydgregory@gmail.com <mailto:garydgregory@gmail.com>>
wrote:
>> 
>> On Mon, Jun 3, 2019 at 9:07 AM Gary Gregory <garydgregory@gmail.com <mailto:garydgregory@gmail.com>>
wrote:
>> 
>>> On Mon, Jun 3, 2019 at 9:00 AM Alex Herbert <alex.d.herbert@gmail.com <mailto:alex.d.herbert@gmail.com>>
>>> wrote:
>>> 
>>>> 
>>>> On 03/06/2019 12:12, Gary Gregory wrote:
>>>>> What about disabling the site-checkout profile like this:
>>>>> 
>>>>> mvn clean install site -Pjacoco -P!setup-checkout
>>>> 
>>>> That works (with the following escape for a bash shell):
>>>> 
>>>> mvn clean install site -Pjacoco -P \!setup-checkout
>>>> 
>>> 
>>> I'm pretty sure setup-checkout is no longer needed, especially since we do
>>> not archive old Javadocs on this component's site.
>>> 
>> 
>> All of this to say that I will remove the profile for future releases.
>> 
> 
> FYI: Same error on MacOS too. It builds fine without the setup-checkout profile.

If the site build is not a blocker then +1.

Downloaded maven artifacts md5, asc, sha1 all OK. I do not know where the .bin, .tar and .zip
artifacts are located to check the SHA-512.


Checkstyle has a few tab characters that were introduced for the recent change to support
header names. It also has a false positive for no header in the pom.properties. This file
is an output of the build and should be excluded from checkstyle.

FindBugs complains about a fall-through. This is documented as deliberate in the code so should
probably be put into an exclusion file for FindBugs so you can use findbugs:check as a goal.

PMD picks up a ternary operator for simplification and an unnecessary final keyword. It complains
about lots of static imports but that seems to be a code style choice for constants. If the
import violations are excluded then the remaining violations can be fixed allowing pmd:check
to work as a goal.

JApiCmp, Rat, all fine.

JaCoCo. I found it odd that the class copied from IO (IOUtils) has no coverage. I had to read
the code to see where it was used. Seems the tests for printing need expanding to output without
quotation marks and with escapes and then without quotation marks or escapes with and without
the output Appendable specified as a Writer.

The absence of a test for writing without quotation marks or escapes is a test case that should
be added. This is the simplest CSV style, i.e. records written as is. The IOUtils class is
used for this as a pass through operation to read input and then write it directly to output
without change.

All can be fixed after release.

Alex

> 
>> Gary
>> 
>> 
>>> 
>>> Gary
>>> 
>>> 
>>>> 
>>>> 
>>>>> ?
>>>>> Gary
>>>>> 
>>>>> On Mon, Jun 3, 2019 at 7:06 AM Alex Herbert <alex.d.herbert@gmail.com
<mailto:alex.d.herbert@gmail.com>>
>>>>> wrote:
>>>>> 
>>>>>> Hi Gary,
>>>>>> 
>>>>>> I've just tried on my Linux setup and get the same error as Bruno.
All
>>>>>> tests pass but the site build doesn't work.
>>>>>> 
>>>>>> mvn -v
>>>>>> 
>>>>>> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
>>>>>> 2018-10-24T19:41:47+01:00)
>>>>>> Maven home: /usr/local/apache-maven-3.6.0
>>>>>> Java version: 1.8.0_212, vendor: Oracle Corporation, runtime:
>>>>>> /usr/lib/jvm/java-8-openjdk-amd64/jre
>>>>>> Default locale: en_GB, platform encoding: UTF-8
>>>>>> OS name: "linux", version: "4.4.0-148-generic", arch: "amd64", family:
>>>>>> "unix"
>>>>>> 
>>>>>> git checkout commons-csv-1.7-RC1
>>>>>> mvn clean install site -Pjacoco
>>>>>> 
>>>>>> [ERROR] Failed to execute goal
>>>>>> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
>>>> (prepare-checkout) on
>>>>>> project commons-csv: An Ant BuildException has occured:
>>>>>> /home/ah403/commons-sites/csv does not exist.
>>>>>> [ERROR] around Ant part ...<pathconvert property="dirs" pathsep="
>>>> ">... @
>>>>>> 10:44 in /home/ah403/git/commons-csv/target/antrun/build-main.xml
>>>>>> 
>>>>>> I cannot try a mac until later when I have my laptop. Maybe someone
>>>> will
>>>>>> get there before me, otherwise I'll do it tonight.
>>>>>> 
>>>>>> Alex
>>>>>> 
>>>>>> 
>>>>>> On 03/06/2019 11:55, Gary Gregory wrote:
>>>>>>> Hi Bruno,
>>>>>>> 
>>>>>>> Hm, that is odd. You are building on Linux or MacOS? I am on
Windows
>>>> 10
>>>>>> and
>>>>>>> I used 'mvn clean install site -Pjacoco'
>>>>>>> 
>>>>>>> Can you try the above?
>>>>>>> 
>>>>>>> Gary
>>>>>>> 
>>>>>>> On Sun, Jun 2, 2019 at 9:09 PM Bruno P. Kinoshita <kinow@apache.org
<mailto:kinow@apache.org>>
>>>>>> wrote:
>>>>>>>> Java 8 on Ubuntu LTS, `mvn clean test` passes OK. But I'm
not able to
>>>>>>>> generate the site with `mvn site`, as it gives me:
>>>>>>>> ```[INFO] --- maven-antrun-plugin:1.8:run (prepare-checkout)
@
>>>>>> commons-csv
>>>>>>>> ---
>>>>>>>> [WARNING] Parameter tasks is deprecated, use target instead
>>>>>>>> [INFO] Executing tasks
>>>>>>>> 
>>>>>>>> main:
>>>>>>>>       [exec] svn: E170000: URL '
>>>>>>>> 
>>>>>> 
>>>> https://svn.apache.org/repos/infra/websites/production/commons/content/proper/csv
<https://svn.apache.org/repos/infra/websites/production/commons/content/proper/csv>
>>>>>> '
>>>>>>>> doesn't exist
>>>>>>>>       [exec] Result: 1
>>>>>>>>       [exec] Skipped '/home/kinow/commons-sites/csv/javadocs'
>>>>>>>>       [exec] svn: E155007: None of the targets are working
copies
>>>>>>>>       [exec] Result: 1
>>>>>>>> [INFO]
>>>>>>>> 
>>>> ------------------------------------------------------------------------
>>>>>>>> [INFO] BUILD FAILURE
>>>>>>>> [INFO]
>>>>>>>> 
>>>> ------------------------------------------------------------------------
>>>>>>>> [INFO] Total time: 2.058 s
>>>>>>>> [INFO] Finished at: 2019-06-03T13:04:02+12:00
>>>>>>>> [INFO]
>>>>>>>> 
>>>> ------------------------------------------------------------------------
>>>>>>>> [ERROR] Failed to execute goal
>>>>>>>> org.apache.maven.plugins:maven-antrun-plugin:1.8:run
>>>> (prepare-checkout)
>>>>>> on
>>>>>>>> project commons-csv: An Ant BuildException has occured:
>>>>>>>> /home/kinow/commons-sites/csv does not exist.
>>>>>>>> [ERROR] around Ant part ...<pathconvert property="dirs"
pathsep="
>>>> ">...
>>>>>> @
>>>>>>>> 10:44 in
>>>>>>>> 
>>>>>> 
>>>> /home/kinow/Development/java/apache/commons-csv/target/antrun/build-main.xml
>>>>>>>> [ERROR] -> [Help 1]
>>>>>>>> [ERROR]
>>>>>>>> [ERROR] To see the full stack trace of the errors, re-run
Maven with
>>>> the
>>>>>>>> -e switch.
>>>>>>>> [ERROR] Re-run Maven using the -X switch to enable full debug
>>>> logging.
>>>>>>>> [ERROR]
>>>>>>>> [ERROR] For more information about the errors and possible
solutions,
>>>>>>>> please read the following articles:
>>>>>>>> [ERROR] [Help 1]
>>>>>>>> 
>>>> http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
>>>>>>>> 
>>>>>>>> 
>>>>>>>> ```
>>>>>>>> Also noticed the tag name pattern changed (which doesn't
really
>>>> bother
>>>>>> me,
>>>>>>>> as it appears to have changed before from CSV_0.0 to csv-0.0,
and
>>>> now is
>>>>>>>> commons-csv-0.0), but checking `csv-1.6`, then doing `mvn
clean test`
>>>>>> also
>>>>>>>> passes, then followed by a `mvn site` it correctly generates
the site
>>>>>> with
>>>>>>>> no issues.
>>>>>>>> So I think there's something between 1.6 and 1.7 that doesn't
allow
>>>> me
>>>>>> to
>>>>>>>> create the site locally.
>>>>>>>> 
>>>>>>>> Bruno
>>>>>>>> 
>>>>>>>> 
>>>>>>>>      On Sunday, 2 June 2019, 12:31:20 pm NZST, Gary Gregory
<
>>>>>>>> ggregory@apache.org> wrote:
>>>>>>>> 
>>>>>>>>   We have fixed quite a few bugs and added some enhancements
since
>>>>>> Apache
>>>>>>>> Commons CSV 1.6 was released, so I would like to release
Apache
>>>> Commons
>>>>>> CSV
>>>>>>>> 1.7.
>>>>>>>> 
>>>>>>>> Apache Commons CSV 1.7 RC1 is available for review here:
>>>>>>>>      https://dist.apache.org/repos/dist/dev/commons/csv/1.7-RC1
>>>> (svn
>>>>>>>> revision 34356)
>>>>>>>> 
>>>>>>>> The Git tag commons-csv-1.7-RC1 commit for this RC is
>>>>>>>> a227a1e2fb61ff5f192cfd8099e7e6f4848d7d43 which you can browse
here:
>>>>>>>> 
>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>>> https://gitbox.apache.org/repos/asf?p=commons-csv.git;a=commit;h=a227a1e2fb61ff5f192cfd8099e7e6f4848d7d43
>>>>>>>> You may checkout this tag using:
>>>>>>>>      git clone https://gitbox.apache.org/repos/asf/commons-csv.git
>>>>>> --branch
>>>>>>>> commons-csv-1.7-RC1 commons-csv-1.7-RC1
>>>>>>>> 
>>>>>>>> Maven artifacts are here:
>>>>>>>> 
>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>>> https://repository.apache.org/content/repositories/orgapachecommons-1440/org/apache/commons/commons-csv/1.7/
>>>>>>>> These are the artifacts and their hashes:
>>>>>>>> 
>>>>>>>> #Release SHA-512s
>>>>>>>> #Sat Jun 01 20:15:22 EDT 2019
>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>>> commons-csv-1.7-bin.tar.gz=0ad5497846a780b470d356ec4519639f39dbc0dd5941dd80a842e641e72b9d28a489808147cd61bc36850ad1cb11578d68f0156c08c5575524671714b519e41d
>>>>>>>> 
>>>>>> 
>>>> commons-csv-1.7-bin.zip=6c593931b4c5a43baf75bb978f62a2f91b83cfa55e4035e95218e255d9be900bd2e7ebef899d8ae986f33ac9e68c9077ae7548a7d42b22fc63c094b06a3903ae
>>>>>>>> 
>>>>>> 
>>>> commons-csv-1.7-javadoc.jar=8a6c17c97f98dc549a79f60ea7bc744c75337ae537bebdf5a4b414d6aade8f5c3b0c948a473ce5a73d8428a267f79bf488fef2b3eb3fdb46aba7d4bd251e21b6
>>>>>>>> 
>>>>>> 
>>>> commons-csv-1.7-sources.jar=17b7ab8aff6deb9dc032c667088f7fffa1c3e8646b16325c25951d51957f0bfa16b4108c94a97348f0c61572bef2cd62ff1efc18352605c36365c342ab68cc2b
>>>>>>>> 
>>>>>> 
>>>> commons-csv-1.7-src.tar.gz=1b82fff41abc43762f1d5c037ac6b2e56097b2ac658335c056f384b9914bfaf73c7cde3474e9f75197b8ed75b4744079e37707f0d6d840480dead291e76e6465
>>>>>>>> 
>>>>>> 
>>>> commons-csv-1.7-src.zip=a560978d89f2336ddb7a81dd44f5e06909ebc3ae44ef777bf21832737e4962185e68f981e221ff7ed9c6ad1efed44b137b392f1bf9eddd366ad5eba5aabb7121
>>>>>>>> 
>>>>>> 
>>>> commons-csv-1.7-test-sources.jar=30ddb09a95a164de4459e9749b37ed8fd287269d4ed179bf90f13ddac6150646ab0c035046a2e0dc29d50d7e0fc9bd2ee3b90530bbcd710007446d6880631cdf
>>>>>>>> 
>>>>>> 
>>>> commons-csv-1.7-tests.jar=343e20a8621fe306a65056b2b2c0d16e8333b4fb7365cbcafe154176f27815866097c946869a039dec5e9d46faa7c60a82c07ce31c53c9f1382430e9f44c7ed1
>>>>>>>> I have tested this with 'mvn clean install site -Pjacoco'
using:
>>>>>>>> 
>>>>>>>> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
>>>>>>>> 2019-04-04T15:00:29-04:00)
>>>>>>>> Maven home: C:\Java\apache-maven-3.6.1\bin\..
>>>>>>>> Java version: 1.8.0_212, vendor: Oracle Corporation, runtime:
>>>> C:\Program
>>>>>>>> Files\Java\jdk1.8.0_212\jre
>>>>>>>> Default locale: en_US, platform encoding: Cp1252
>>>>>>>> OS name: "windows 10", version: "10.0", arch: "amd64", family:
>>>> "windows"
>>>>>>>> 
>>>>>>>> Details of changes since 1.6 are in the release notes:
>>>>>>>> 
>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>>> https://dist.apache.org/repos/dist/dev/commons/csv/1.7-RC1/RELEASE-NOTES.txt
>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>>> https://dist.apache.org/repos/dist/dev/commons/csv/1.7-RC1/site/changes-report.html
>>>>>>>> Site:
>>>>>>>> 
>>>>>> 
>>>> https://dist.apache.org/repos/dist/dev/commons/csv/1.7-RC1/site/index.html
>>>>>>>>      (note some *relative* links are broken and the 1.7 directories
>>>> are
>>>>>> not
>>>>>>>> yet created - these will be OK once the site is deployed.)
>>>>>>>> 
>>>>>>>> JApiCmp Report (compared to 1.6):
>>>>>>>> 
>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>>> https://dist.apache.org/repos/dist/dev/commons/csv/1.7-RC1/site/japicmp.html
>>>>>>>> RAT Report:
>>>>>>>> 
>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>>> https://dist.apache.org/repos/dist/dev/commons/csv/1.7-RC1/site/rat-report.html
>>>>>>>> KEYS:
>>>>>>>>    https://www.apache.org/dist/commons/KEYS
>>>>>>>> 
>>>>>>>> Please review the release candidate and vote.
>>>>>>>> This vote will close no sooner that 72 hours from now.
>>>>>>>> 
>>>>>>>>    [ ] +1 Release these artifacts
>>>>>>>>    [ ] +0 OK, but...
>>>>>>>>    [ ] -0 OK, but really should fix...
>>>>>>>>    [ ] -1 I oppose this release because...
>>>>>>>> 
>>>>>>>> Thank you,
>>>>>>>> 
>>>>>>>> Gary Gregory,
>>>>>>>> Release Manager (using key 86fdc7e2a11262cb)
>>>>>>>> 
>>>>>>>> For following is intended as a helper and refresher for reviewers.
>>>>>>>> 
>>>>>>>> Validating a release candidate
>>>>>>>> ==============================
>>>>>>>> 
>>>>>>>> These guidelines are NOT complete.
>>>>>>>> 
>>>>>>>> Requirements: Git, Java, Maven.
>>>>>>>> 
>>>>>>>> You can validate a release from a release candidate (RC)
tag as
>>>> follows.
>>>>>>>> 
>>>>>>>> 1) Clone and checkout the RC tag
>>>>>>>> 
>>>>>>>> git clone https://gitbox.apache.org/repos/asf/commons-csv.git
>>>> --branch
>>>>>>>> commons-csv-1.7-RC1 commons-csv-1.7-RC1
>>>>>>>> cd commons-csv-1.7-RC1
>>>>>>>> 
>>>>>>>> 2) Check Apache licenses
>>>>>>>> 
>>>>>>>> This step is not required if the site includes a RAT report
page
>>>> which
>>>>>> you
>>>>>>>> then must check.
>>>>>>>> 
>>>>>>>> mvn apache-rat:check
>>>>>>>> 
>>>>>>>> 3) Check binary compatibility
>>>>>>>> 
>>>>>>>> Older components still use Apache Clirr:
>>>>>>>> 
>>>>>>>> This step is not required if the site includes a Clirr report
page
>>>> which
>>>>>>>> you then must check.
>>>>>>>> 
>>>>>>>> mvn clirr:check
>>>>>>>> 
>>>>>>>> Newer components use JApiCmp with the japicmp Maven Profile:
>>>>>>>> 
>>>>>>>> This step is not required if the site includes a JApiCmp
report page
>>>>>> which
>>>>>>>> you then must check.
>>>>>>>> 
>>>>>>>> mvn install -DskipTests -P japicmp japicmp:cmp
>>>>>>>> 
>>>>>>>> 4) Build the package
>>>>>>>> 
>>>>>>>> mvn -V clean package
>>>>>>>> 
>>>>>>>> You can record the Maven and Java version produced by -V
in your VOTE
>>>>>>>> reply.
>>>>>>>> To gather OS information from a command line:
>>>>>>>> Windows: ver
>>>>>>>> Linux: uname -a
>>>>>>>> 
>>>>>>>> 5) Build the site for a single module project
>>>>>>>> 
>>>>>>>> Note: Some plugins require the components to be installed
instead of
>>>>>>>> packaged.
>>>>>>>> 
>>>>>>>> mvn site
>>>>>>>> Check the site reports in:
>>>>>>>> - Windows: target\site\index.html
>>>>>>>> - Linux: target/site/index.html
>>>>>>>> 
>>>>>>>> 6) Build the site for a multi-module project
>>>>>>>> 
>>>>>>>> mvn site
>>>>>>>> mvn site:stage
>>>>>>>> Check the site reports in:
>>>>>>>> - Windows: target\site\index.html
>>>>>>>> - Linux: target/site/index.html
>>>>>>>> 
>>>>>>>> -end-
> 


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message