commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [configuration] review for PR 30
Date Mon, 01 Jul 2019 23:59:41 GMT
On Mon, Jul 1, 2019 at 6:46 PM Emmanuel Bourg <ebourg@apache.org> wrote:

> Le 01/07/2019 à 16:26, Gary Gregory a écrit :
>
> > May anyone that knows enough of the internals of [configuration] please
> > comment on https://github.com/apache/commons-configuration/pull/30
>
> I got a quick look, besides the setArrayProperty method that doesn't
> seem to have the right name (there is nothing specific to arrays in the
> implementation, it just sets the value as is) the PR looks good.
>

What would you call the method?

Gary


>
> Emmanuel Bourg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message