commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Sicker <boa...@gmail.com>
Subject Re: [commons-dbcp] branch master updated: [DBCP-547] Add a ConnectionFactory class name setting for BasicDataSource.createConnectionFactory() #33.
Date Thu, 11 Jul 2019 13:40:51 GMT
Thanks, Mark! I’m in complete agreement on your formatting philosophy here
(consistency over bikeshedding). And also kinda like the new line after
operator, too, though no strong opinion there since I seem to forget which
style I prefer sometimes.

On Thu, Jul 11, 2019 at 04:21, Mark Thomas <markt@apache.org> wrote:

> On 10/07/2019 22:47, Gary Gregory wrote:
> > On Wed, Jul 10, 2019 at 11:52 AM Mark Thomas <markt@apache.org> wrote:
> >
> >> On 10/07/2019 15:49, Gary Gregory wrote:
> >>
> >>> Without arguing about the merits of one kind of formatting vs.
> another...
> >>> If you can configure the Eclipse formatter to do that, I'd consider it,
> >>> otherwise, I'm not into what I'd call "artisanal formatting" ;-)
> >>
> >>
> >> The Eclipse setting you want is:
> >>
> >> Formatter > Line Wrapping > Default indentation for wrapped lines
> >>
> >> and set it to 2 (which should be the default).
> >>
> >>
> >> That seems to do the trick when I run it locally. I'd commit the result
> >> but the default settings change nearly every line in the file.
> >>
> >> Looking more closely, that appears to be a line ending issue. I thought
> >> the accepted practice was to use unix line endings in the repo and
> >> native line endings locally. It looks like there are some Windows line
> >> endings in the repo.
> >>
> >> It would be worth saving your Eclipse formatter settings in the source
> >> tree somewhere so everybody can work from the same set.
> >>
> >
> > I set the setting you mentioned to 2 and saved my config
> > here: src/conf/eclipse/formatter.xml
> > I did not reformat anything.
>
> Thanks. I applied that to BasicDataSource.
>
> I haven't applied that formatting to all files although it probably
> makes sense to do so.
>
> I've looked through the formatting and my personal preference would be
> to change one more thing (actually a handful of settings for different
> operators):
> - wrap before operator -> wrap after operator
>
> but that is a low priority for me. If the consensus is against that I'm
> fine with that. I'd rather spend time convincing people it is helpful
> for the project to use a consistent formatting throughout than endlessly
> debate the merits of each individual option.
>
> I also fixed the line endings of the 10 or so files that were using \r\n
> line endings rather than the recommended \n.
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
> --
Matt Sicker <boards@gmail.com>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message