commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [commons-lang] branch master updated: Spotbugs is already run as part of the Maven default build goal.
Date Thu, 12 Sep 2019 19:53:18 GMT
On Thu, Sep 12, 2019 at 3:49 PM Alex Herbert <alex.d.herbert@gmail.com>
wrote:

> A typo in this commit, see below.
>
> > On 12 Sep 2019, at 14:09, ggregory@apache.org wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > ggregory pushed a commit to branch master
> > in repository https://gitbox.apache.org/repos/asf/commons-lang.git
> >
> >
> > The following commit(s) were added to refs/heads/master by this push:
> >     new e144ca6  Spotbugs is already run as part of the Maven default
> build goal.
> > e144ca6 is described below
> >
> > commit e144ca6816168867e6a96a93298f8c124029c764
> > Author: Gary Gregory <gardgregory@gmail.com>
> > AuthorDate: Thu Sep 12 09:09:20 2019 -0400
> >
> >    Spotbugs is already run as part of the Maven default build goal.
> > ---
> > .travis.yml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/.travis.yml b/.travis.yml
> > index b651149..300a964 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -32,4 +32,4 @@ script:
> >   - mvn
> >
> > after_success:
> > -  - mvn clean test spotbugs:check jacoco:report coveralls:report
> -Ptravis-jacoco javadoc:javadoc -Ddoclint=all
> > +  - mvn clean test acoco:report coveralls:report -Ptravis-jacoco
> javadoc:javadoc -Ddoclint=all
>
> Missing a j from jacoco:report
>

Thanks! Fixed in git master.

Gary


>
> IIUC an error in ‘after_success' will not break the build [1] so this will
> not be flagged by Travis and coverage reports will go missing:
>
> [1] https://docs.travis-ci.com/user/job-lifecycle#breaking-the-build <
> https://docs.travis-ci.com/user/job-lifecycle#breaking-the-build>
>
> >
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message