commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [RNG] LGTM analysis (Was: [...] branch master updated: Badge.)
Date Thu, 24 Oct 2019 15:48:55 GMT
On Thu, 24 Oct 2019 at 16:36, Alex Herbert <alex.d.herbert@gmail.com> wrote:
>
>
>
> > On 24 Oct 2019, at 16:23, Gilles Sadowski <gilleseran@gmail.com> wrote:
> >
> > Hello.
> >
> > "Commons RNG" page on GitHub[1] now links to the LGTM report[2].
> >
> > Unfortunately, the one "alert" there[3] is a false positive.
> > Perhaps, we could make it go away by rewriting the "while" loop
> > as a "for" loop... (or changing the bound to "size - 1”).
>
> I saw that.
>
> The loop was written to avoid an if statement within the loop. I’ll see if a variant
can pass the LGTM check.

If you do change the code, best to add a comment as to why the
particular syntax is being used.

> Alex
>
>
> >
> > Regards,
> > Gilles
> >
> > [1] https://github.com/apache/commons-rng
> > [2] https://lgtm.com/projects/g/apache/commons-rng/context:java
> > [3] https://lgtm.com/projects/g/apache/commons-rng/snapshot/8504c91b999959c38e97a69ed1d9f71f41e3bd40/files/commons-rng-simple/src/main/java/org/apache/commons/rng/simple/internal/Long2IntArray.java
> >
> >> [...]
> >>
> >> commit 5461d28594d006365b20a4748957656208c3a599
> >> Author: Gilles Sadowski <gilles@harfang.homelinux.org>
> >> AuthorDate: Thu Oct 24 17:08:08 2019 +0200
> >>
> >>    Badge.
> >> [...]
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message