commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Siegfried Goeschl (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (SANDBOX-51) [exec] EnvironmentVariable: inline private constructor
Date Wed, 02 Jan 2008 17:43:34 GMT

     [ https://issues.apache.org/jira/browse/SANDBOX-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Siegfried Goeschl resolved SANDBOX-51.
--------------------------------------

    Resolution: Won't Fix

Since there is no EnvironmentVariable in the code base I can not apply the patch

> [exec] EnvironmentVariable: inline private constructor
> ------------------------------------------------------
>
>                 Key: SANDBOX-51
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-51
>             Project: Commons Sandbox
>          Issue Type: Bug
>          Components: Exec
>         Environment: Operating System: other
> Platform: Other
>            Reporter: Jerome Lacoste
>            Assignee: Siegfried Goeschl
>         Attachments: 36796_environment_variable_inline_constructor.diff
>
>
> Move the key=value String parsing inside the factory method and remove the
> private constructor.
> There's no need for both and parsing logic is better outside of a constructor
> (as a rule and to make things similar with the rest of the code), especially whe
> n there's already a factory.
> Removing the constructor doesn't create an issue as it's private and there's
> already another private one.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message