commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-758) Fields which could be private and/or final
Date Sat, 03 Mar 2012 03:21:59 GMT

    [ https://issues.apache.org/jira/browse/MATH-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221490#comment-13221490
] 

Gilles commented on MATH-758:
-----------------------------

I totally agree on the data encapsulation issue.

The problem is the timing: It is not the appropriate time to make large modifications to the
code because almost 2 years of work must released.

Most of these issues are going to stay at the level of "potential problems" (the field are
not intended to be directly accessed by users) as they have been until now.
I must point again that those issues stem from not having a consistent coding policy, e.g.
a rule such as "It's never necessary to expose mutable data fields directly". This rule should
be integrated when thinking about the implementation, not as an after-thought. Redesigning
some of the affected implementations will need more time than I have now.


                
> Fields which could be private and/or final
> ------------------------------------------
>
>                 Key: MATH-758
>                 URL: https://issues.apache.org/jira/browse/MATH-758
>             Project: Commons Math
>          Issue Type: Bug
>            Reporter: Sebb
>
> BaseAbstractUnivariateIntegrator has several fields that are not currently changed after
construction and could be final:
> protected double absoluteAccuracy;
> protected double relativeAccuracy;
> protected int minimalIterationCount;
> protected Incrementor iterations;
> protected Incrementor evaluations;
> These all have getters as well, so could also be made private.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message