commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Bergholm (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (VFS-426) HTTP URL query string not part of cache key
Date Fri, 29 Jun 2012 20:17:43 GMT

    [ https://issues.apache.org/jira/browse/VFS-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404167#comment-13404167
] 

Daniel Bergholm commented on VFS-426:
-------------------------------------

Certainly:
{code:java}
@Test
public void shouldResolveUrls() throws FileSystemException {
        String firstUrl = "http://commons.apache.org/vfs";
        String secondUrl = "http://commons.apache.org/vfs?query=string";

        FileSystemManager fileSystemManager = VFS.getManager();

        FileObject firstResult = fileSystemManager.resolveFile(firstUrl);
        assertEquals(firstUrl, firstResult.getURL().toExternalForm());

        FileObject secondResult = fileSystemManager.resolveFile(secondUrl);
        assertEquals(secondUrl, secondResult.getURL().toExternalForm()); // fails
}{code}
                
> HTTP URL query string not part of cache key
> -------------------------------------------
>
>                 Key: VFS-426
>                 URL: https://issues.apache.org/jira/browse/VFS-426
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: Daniel Bergholm
>
> I am using commons-vfs amongst other things to download http files. When resolving different
URLs where only the query string differs, the default cache returns the wrong URL sometimes
(returning a previously accessed URL where only the query string differs).
> I think this is because the key property of URLFileName does not include the query string.
The {code:java}createURI(){code} method of URLFileName does include it, but when constructing
the key the {code:java}createURI(boolean useAbsolutePath, boolean usePassword){code} method
of AbstractFileName is used. This method only includes the path. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message