commons-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luc Maisonobe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MATH-889) Add a method in Interval that verifies if a double is inside the Interval
Date Sun, 04 Nov 2012 19:58:12 GMT

    [ https://issues.apache.org/jira/browse/MATH-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490284#comment-13490284
] 

Luc Maisonobe commented on MATH-889:
------------------------------------

In the same package, there is another class, IntervalsSet, which provides a checkPoint method
inherited from its top level interface Region<Space>. The specification for this method
is:

{code}
    /** Check a point with respect to the region.
     * @param point point to check
     * @return a code representing the point status: either {@link
     * Location#INSIDE}, {@link Location#OUTSIDE} or {@link Location#BOUNDARY}
     */
    Location checkPoint(final Vector<S> point);
{code}

Wouldn't it be more consistent to use a similar method in Interval, using a simple double
as the parameter but returning the same type as the original method, i.e. a Location enum?
We could also add a threshold parameter for Location.BOUNDARY.
                
> Add a method in Interval that verifies if a double is inside the Interval
> -------------------------------------------------------------------------
>
>                 Key: MATH-889
>                 URL: https://issues.apache.org/jira/browse/MATH-889
>             Project: Commons Math
>          Issue Type: Improvement
>    Affects Versions: 3.0
>            Reporter: Ramiro Pereira de Magalhães
>            Priority: Minor
>
> It would be convenient if class org.apache.commons.math3.geometry.euclidean.oned.Interval
had a method such as the one below.
> {code}
> Here is the method code that may be added to the class.
>     /** Verifies if x is inside this Interval.
>      * @return true if x is a value between this Interval lower and upper
>      * bounds, false otherwise
>      */
>     public boolean contains(double x) {
>         return upper >= x && lower <= x;
>     }
> {code}
> Notice that I'm assuming that an Interval includes its endpoints which may not be true
in certain applications. This may imply the need to improve the Interval class (by adding
methods or internal state) that describe the inclusion or exclusion of endpoints.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message